Review 9.5 Merged

61842[BUGFIX] Page preview respects language fallbacks

Benni Mack CR +2 V +2 Easy +21 −5 updated 09/28/19, 08:59

Commit message

When a default language page is hidden, it should also be visible
when a translated page is rendered but not available.

The current "simple" check to only check for a specific language
to find out if a page is hidden, is wrong, as l18n_cfg could be built
in a way that a page translation (language>0) does not exist, but
the default record is actually available.

This change overcomes a long-standing issue that
translations of hidden pages can be previewed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • anonymized-52878 +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • anonymized-52878 +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 09/26/19, 12:21

  2. TYPO3com voted on patch set 1 V +1 09/26/19, 12:34 Completed build in 13m 14s on Thu, 26 Sep, 12:34 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1216

  3. anonymized-52878 commented on patch set 1 09/26/19, 12:51

    In my setup the patch has no effect. Previewing a translated page which is not available but should fallback to default language, where default language page is hidden, results still in a 404 Error.
  4. Benni Mack uploaded patch set 2 09/27/19, 13:52

  5. TYPO3com voted on patch set 2 V +1 09/27/19, 14:07 Completed build in 14m 39s on Fri, 27 Sep, 02:07 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1221

  6. anonymized-52878 commented on patch set 2 V +1 CR +1 09/27/19, 14:40

    Patch verified.
  7. Daniel Goerz voted on patch set 2 V +2 CR +2 09/28/19, 08:59

  8. Daniel Goerz merged patch set 3 09/28/19, 08:59