Review main Merged

61845[BUGFIX] Fix several typos in php comments

Christian Eßl CR +2 V +2 Hard +386 −386 updated 10/25/19, 09:44

Commit message

Make spelling in TYPO3 great again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 248

Show 228 more files

Review log 1519

  1. Christian Eßl uploaded patch set 1 09/26/19, 19:39

  2. TYPO3com voted on patch set 1 V -1 09/26/19, 19:48 Completed build in 09m 00s on Thu, 26 Sep, 07:48 PM Test Summary: 47675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36867

  3. Björn Jacob commented on patch set 1 CR -1 09/26/19, 20:15

    PagesVisibleFieldsTest.php:26

    "are"

    AbstractDomainObject.php:310 Unresolved

    Does the second "cloned," make any sense?

    Query.php:218 Unresolved

    "selector's"

    FormManagerController.php:287 Unresolved

    "This list"?

    ConditionProvider.php:23 Unresolved

    Remove whitespace.

    RenderableInterface.php:68 Unresolved

    "of the form"?

    AbstractMenuContentObject.php:2056 Unresolved

    "a"

    PagesLanguageOverlayVisibleFieldsTest.php:26 Unresolved

    "are"

    Import.php:685 Unresolved

    Superfluous?

    Import.php:1496 Unresolved

    "ressource's"

    PluginHook.php:23 Unresolved

    ? Maybe "convention"?

    DatabaseRecordList.php:2987 Unresolved

    No, I think "PageTS" is meant.
  4. Christian Eßl uploaded patch set 2 09/27/19, 11:58

  5. TYPO3com voted on patch set 2 V -1 09/27/19, 12:09 Completed build in 11m 22s on Fri, 27 Sep, 12:09 PM Test Summary: 47676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36885

  6. Oliver Klee commented on patch set 2 09/27/19, 12:10

    Should we also have this in 9.5 so cherry-picks of other changed later down the road are more likely to be smooth?
  7. Benni Mack commented on patch set 2 09/28/19, 21:28

    btw... great patch!!! IMHO highly important.
  8. Benni Mack commented on patch set 2 09/28/19, 21:28

    Reply

    maybe we could do a separate change only targetted to 9.5? I guess there is more code docs to change!
  9. TYPO3com commented on patch set 2 09/28/19, 21:30 Completed build in 9h 43m 50s on Sat, 28 Sep, 09:30 PM Test Summary: 47676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36885

  10. Christian Eßl commented on patch set 2 09/30/19, 16:28

    Reply Unresolved

    I initially chose only master because I was afraid, that a merge to 9.5 might involve too many conflicts that need resolving. But I'm pretty new to gerrit and open for suggestions. ;)
  11. Andreas Kienast commented on patch set 2 CR -1 10/01/19, 06:23

    copyformatting.css:26

    This is a 3rd party file copied by Grunt, it makes no sense to adjust that file. BTW this change breaks your build.
  12. Christian Eßl uploaded patch set 3 10/01/19, 06:45

  13. Christian Eßl commented on patch set 3 10/01/19, 06:48

    PagesVisibleFieldsTest.php:26 Reply

    Done

    copyformatting.css:26 Reply

    Thanks! That must have slipped through. The patch should have been just about php comments. :)
  14. TYPO3com voted on patch set 3 V +1 10/01/19, 07:10 Completed build in 24m 14s on Tue, 1 Oct, 07:10 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36978

  15. Daniel Goerz voted on patch set 3 V +1 CR +1 10/06/19, 17:44

  16. Jörg Bösche voted on patch set 3 V +1 CR +1 10/07/19, 10:32

  17. Daniel Goerz voted on patch set 3 V +2 CR +2 10/07/19, 10:35

  18. Daniel Goerz merged patch set 4 10/07/19, 10:35

  19. Frank Nägler commented on patch set 4 10/25/19, 09:44

    AbstractMenuContentObjectTest.php:552 Unresolved

    post -1: This breaks the test, because renaming the rename of the dataProvider annotation requires also a rename of the dataProvider it self.