61845[BUGFIX] Fix several typos in php comments
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Jörg Bösche +1
-
Verified V +2 Done
- Daniel Goerz +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 248
- typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php+1 −1
- typo3/sysext/backend/Classes/Backend/Avatar/AvatarProviderInterface.php+1 −1
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+1 −1
- typo3/sysext/backend/Classes/Configuration/BackendUserConfiguration.php+3 −3
- typo3/sysext/backend/Classes/Configuration/TsConfigParser.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+1 −1
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseUniqueUidNewRow.php+1 −1
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldWizard.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php+3 −3
- typo3/sysext/backend/Classes/Provider/PageTsBackendLayoutDataProvider.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/QueryParser.php+2 −2
Show 228 more files
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Classes/Tree/Renderer/AbstractTreeRenderer.php+1 −1
- typo3/sysext/backend/Classes/Tree/Renderer/UnorderedListTreeRenderer.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −3
- typo3/sysext/backend/Classes/View/PageLayoutView.php+4 −4
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+1 −1
- typo3/sysext/backend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTypesShowitemTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/FullyRenderedButtonTest.php+1 −1
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Cache/Backend/MemcachedBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+3 −3
- typo3/sysext/core/Classes/Cache/Frontend/FrontendInterface.php+1 −1
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+1 −1
- typo3/sysext/core/Classes/Collection/NameableCollectionInterface.php+3 −3
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+4 −4
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+2 −2
- typo3/sysext/core/Classes/Configuration/Richtext.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Argon2iPasswordHash.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PasswordHashInterface.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Pbkdf2PasswordHash.php+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Types/EnumType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Types/SetType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+2 −2
- typo3/sysext/core/Classes/Database/Connection.php+1 −1
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/Database/RelationHandler.php+2 −2
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+3 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+4 −4
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+1 −1
- typo3/sysext/core/Classes/Http/Uri.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+3 −3
- typo3/sysext/core/Classes/Imaging/IconFactory.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LinkHandlingInterface.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+1 −1
- typo3/sysext/core/Classes/Mail/FileSpool.php+1 −1
- typo3/sysext/core/Classes/Mail/MailMessage.php+2 −2
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+1 −1
- typo3/sysext/core/Classes/Messaging/AbstractMessage.php+1 −1
- typo3/sysext/core/Classes/Package/PseudoServiceProvider.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+4 −4
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+1 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/OnlineMediaHelperRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+3 −3
- typo3/sysext/core/Classes/Resource/Security/StoragePermissionsAspect.php+1 −1
- typo3/sysext/core/Classes/Resource/AbstractFile.php+1 −1
- typo3/sysext/core/Classes/Resource/FileCollectionRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+4 −4
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+2 −2
- typo3/sysext/core/Classes/Routing/Route.php+2 −2
- typo3/sysext/core/Classes/Service/AbstractService.php+1 −1
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php+3 −3
- typo3/sysext/core/Classes/Site/SiteFinder.php+1 −1
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+2 −2
- typo3/sysext/core/Classes/Tree/TableConfiguration/AbstractTableConfigurationTreeDataProvider.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/ArrayTreeRenderer.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+1 −1
- typo3/sysext/core/Classes/Type/File/FileInfo.php+2 −2
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+2 −2
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TypoScriptService.php+2 −2
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/CsvUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+6 −6
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+5 −5
- typo3/sysext/core/Classes/Utility/PathUtility.php+1 −1
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/FalMetadataInheritanceCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Login/BackendLoginCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/BookmarkCest.php+1 −1
- typo3/sysext/core/Tests/Functional/Collection/RecordCollectionRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/CheckValueTestForCheckboxes.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/QueueController.php+1 −1
- typo3/sysext/core/Tests/Functional/Tca/PagesVisibleFieldsTest.php2+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/Fixtures/DataStructureIdentifierPreProcessHookReturnEmptyArray.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Http/NormalizedParamsTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/CompleteEnumeration.php+1 −1
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+1 −1
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php+1 −1
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+2 −2
- typo3/sysext/extbase/Classes/Domain/Model/BackendUserGroup.php+1 −1
- typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php1+3 −3
- typo3/sysext/extbase/Classes/Error/Result.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerInterface.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/RequestInterface.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Comparison.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/ComparisonInterface.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Exception/BadConstraintException.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+5 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php1+1 −1
- typo3/sysext/extbase/Classes/Persistence/ClassesConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+1 −1
- typo3/sysext/extbase/Classes/Property/Exception.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfigurationBuilder.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+1 −1
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/Testclasses.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/Fixture/AbstractCompositeValidatorClass.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/Fixture/AbstractValidatorClass.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractExtensionXmlParser.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractMirrorXmlParser.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DistributionImageViewHelper.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+3 −3
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/AjaxWidgetContextHolder.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/HtmlentitiesViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/StripTagsViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/UrlencodeViewHelperTest.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php1+2 −2
- typo3/sysext/form/Classes/Domain/Condition/ConditionProvider.php1+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidator.php+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidator.php+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionValidationService.php+2 −2
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+5 −5
- typo3/sysext/form/Classes/Domain/Finishers/DeleteUploadsFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableInterface.php1+2 −2
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+2 −2
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+1 −1
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+2 −2
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+4 −4
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php1+4 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+6 −6
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −2
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+3 −3
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+1 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+2 −2
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+2 −2
- typo3/sysext/frontend/Classes/Utility/CompressionUtility.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Tca/PagesLanguageOverlayVisibleFieldsTest.php1+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php1+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+7 −7
- typo3/sysext/impexp/Classes/ContextMenu/ItemProvider.php+1 −1
- typo3/sysext/impexp/Classes/Hook/BackendControllerHook.php+1 −1
- typo3/sysext/impexp/Classes/Export.php+2 −2
- typo3/sysext/impexp/Classes/Import.php2+2 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Example/PluginHook.php1+1 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+2 −2
- typo3/sysext/indexed_search/Classes/Utility/DoubleMetaPhoneUtility.php+1 −1
- typo3/sysext/indexed_search/Classes/Utility/IndexedSearchUtility.php+2 −2
- typo3/sysext/indexed_search/Classes/FileContentParser.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+2 −2
- typo3/sysext/install/Classes/Configuration/Image/AbstractImagePreset.php+1 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+1 −1
- typo3/sysext/install/Classes/Controller/InstallerController.php+2 −2
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+1 −1
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcher.php+2 −2
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php+1 −1
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+1 −1
- typo3/sysext/install/Classes/Service/LanguagePackService.php+1 −1
- typo3/sysext/install/Classes/Service/LoadTcaService.php+1 −1
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodCallStaticMatcherFixture.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Utility/ArrayBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php1+4 −4
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+2 −2
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.php+1 −1
- typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php+1 −1
- typo3/sysext/recycler/ext_tables.php+1 −1
- typo3/sysext/scheduler/Classes/Example/SleepTaskAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+1 −1
- typo3/sysext/scheduler/Tests/Unit/CronCommand/CronCommandTest.php+1 −1
- typo3/sysext/t3editor/Classes/Controller/CodeCompletionController.php+1 −1
- typo3/sysext/t3editor/Classes/Controller/TypoScriptReferenceController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+1 −1
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+6 −6
- typo3/sysext/workspaces/Classes/Domain/Model/CombinedRecord.php+2 −2
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+3 −3
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+4 −4
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+1 −1
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −1
- typo3/sysext/workspaces/Classes/Service/IntegrityService.php+3 −3
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+1 −1
Review log 1519
-
Christian Eßl uploaded patch set 1 09/26/19, 19:39
-
TYPO3com voted on patch set 1 V -1 09/26/19, 19:48 Completed build in 09m 00s on Thu, 26 Sep, 07:48 PM Test Summary: 47675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36867
-
Björn Jacob commented on patch set 1 CR -1 09/26/19, 20:15
AbstractDomainObject.php:310UnresolvedDoes the second "cloned," make any sense?Query.php:218Unresolved"selector's"FormManagerController.php:287Unresolved"This list"?ConditionProvider.php:23UnresolvedRemove whitespace.RenderableInterface.php:68Unresolved"of the form"?AbstractMenuContentObject.php:2056Unresolved"a"PagesLanguageOverlayVisibleFieldsTest.php:26Unresolved"are"Import.php:685UnresolvedSuperfluous?Import.php:1496Unresolved"ressource's"PluginHook.php:23Unresolved? Maybe "convention"?DatabaseRecordList.php:2987UnresolvedNo, I think "PageTS" is meant. -
Christian Eßl uploaded patch set 2 09/27/19, 11:58
-
TYPO3com voted on patch set 2 V -1 09/27/19, 12:09 Completed build in 11m 22s on Fri, 27 Sep, 12:09 PM Test Summary: 47676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36885
-
Oliver Klee commented on patch set 2 09/27/19, 12:10
Should we also have this in 9.5 so cherry-picks of other changed later down the road are more likely to be smooth? -
Benni Mack commented on patch set 2 09/28/19, 21:28
btw... great patch!!! IMHO highly important. -
Benni Mack commented on patch set 2 09/28/19, 21:28
Reply
maybe we could do a separate change only targetted to 9.5? I guess there is more code docs to change! -
TYPO3com commented on patch set 2 09/28/19, 21:30 Completed build in 9h 43m 50s on Sat, 28 Sep, 09:30 PM Test Summary: 47676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36885
-
Christian Eßl commented on patch set 2 09/30/19, 16:28
Reply Unresolved
I initially chose only master because I was afraid, that a merge to 9.5 might involve too many conflicts that need resolving. But I'm pretty new to gerrit and open for suggestions. ;) -
Andreas Kienast commented on patch set 2 CR -1 10/01/19, 06:23
copyformatting.css:26This is a 3rd party file copied by Grunt, it makes no sense to adjust that file. BTW this change breaks your build. -
Christian Eßl uploaded patch set 3 10/01/19, 06:45
-
Christian Eßl commented on patch set 3 10/01/19, 06:48
PagesVisibleFieldsTest.php:26ReplyDonecopyformatting.css:26ReplyThanks! That must have slipped through. The patch should have been just about php comments. :) -
TYPO3com voted on patch set 3 V +1 10/01/19, 07:10 Completed build in 24m 14s on Tue, 1 Oct, 07:10 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36978
-
Daniel Goerz voted on patch set 3 V +1 CR +1 10/06/19, 17:44
-
Jörg Bösche voted on patch set 3 V +1 CR +1 10/07/19, 10:32
-
Daniel Goerz voted on patch set 3 V +2 CR +2 10/07/19, 10:35
-
Daniel Goerz merged patch set 4 10/07/19, 10:35
-
Frank Nägler commented on patch set 4 10/25/19, 09:44
AbstractMenuContentObjectTest.php:552Unresolvedpost -1: This breaks the test, because renaming the rename of the dataProvider annotation requires also a rename of the dataProvider it self.
PagesVisibleFieldsTest.php:26