Review main Merged

61846[TASK] Add configuration for Crowdin

Georg Ringer CR +2 V +2 Easy +4 −0 updated 10/02/19, 13:06

Commit message

Crowdin requires a basic configuration which defines where the
XLIFF files and their translations are located. The configuration is used
by the GitHub integration which is offered by Crowdin itself.
See https://support.crowdin.com/github-integration/ for more information
about that.

Even though the translations will not be pushed back to the GitHub
repository of TYPO3 (as pull requests), the "translation" property is
required as the manual export of translations will use it.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1923

  1. Georg Ringer uploaded patch set 1 09/26/19, 20:27

  2. Georg Ringer commented on patch set 1 09/26/19, 20:28

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/26/19, 20:39 Completed build in 11m 06s on Thu, 26 Sep, 08:39 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36869

  4. Benjamin Franzke commented on patch set 1 09/26/19, 21:06

    I can not grasp what this configuration will actually do, especially tNeither from the commit message

    .crowdin.yml:3 Unresolved

    Reading the documentation on https://support.crowdin.com/configuration-file/ this directive means that `crowdin download` will put files like 'de.locallang.xlf' into /typo3/sysext/%ext%/Resources/Private/Language/. Please elaborate (in the commit message): * How will the (downloaded) files be further used/processed from that location. I mean, wouldn't it be better to put them in some gitignored folder(prefix)? * Who will be able to use `crowdin download` (in order to test this) Is this intended to be used by every core contributor or is this setting targeted for language-pack preparation?
  5. Benjamin Franzke commented on patch set 1 09/26/19, 21:16

    Forget about the sentence "I can not grasp what this configuration will actually do, especially tNeither from the commit message". That refered to "translation" settings only and was too generic, therefore I wanted to delete it, but forgot before pressing "Reply" after adding the inline comment to the "translation" directive.
  6. Georg Ringer commented on patch set 1 09/27/19, 08:59

    Crowdin fetches translations from github integration using this configuration. The translations won't be added to git but will be downloaded later by different code.
  7. Georg Ringer commented on patch set 1 09/27/19, 09:00

    More docs for the full integration will follow
  8. Benjamin Franzke commented on patch set 1 09/27/19, 09:05

    > but will be downloaded later by different code. Ok, will that (downloading) code rely on the "translation" setting to be defined or could it be omitted?
  9. Georg Ringer commented on patch set 1 09/27/19, 10:06

    The translation setting is required because this will also be used for the structure of the download
  10. Georg Ringer commented on patch set 1 CR -2 09/30/19, 12:50

    not ready
  11. Georg Ringer commented on patch set 1 CR 0 10/02/19, 03:42

  12. Markus Klein voted on patch set 1 V +1 CR +1 10/02/19, 08:39

  13. Benjamin Franzke commented on patch set 1 CR -1 10/02/19, 09:05

    Please add the explanation, why both of these properties are required in our usecase to the commit message. Github wiki links are non persistent and can be outdated in future, which will make it hard to git-blame for reasons why e.g. the "translation" property has been added. Maybe even add a link to https://support.crowdin.com/github-integration/ would be useful, if that's what TYPO3 will be using. Also, https://support.crowdin.com/github-integration/ suggests the file to be named .crowdin.yaml, why do we name it .crowdin.yml? And another question, according to https://support.crowdin.com/github-integration/ crowdin will send pull requests to the github repository. Can those pull requests be disabled when using the github integration, or will github.com/TYPO3/TYPO3.CMS be flooded with pull requests (which're then mirrored to gerrit)?
  14. Georg Ringer uploaded patch set 2 10/02/19, 11:21

  15. TYPO3com voted on patch set 2 V -1 10/02/19, 11:31 Completed build in 09m 47s on Wed, 2 Oct, 11:31 AM Test Summary: 47750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37008

  16. TYPO3com voted on patch set 2 V +1 10/02/19, 11:40 Completed build in 28m 52s on Wed, 2 Oct, 11:40 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37008

  17. Georg Ringer wrote 10/02/19, 11:57

    Hashtag added: crowdin
  18. Markus Klein voted on patch set 2 V +1 CR +1 10/02/19, 12:22

  19. Benjamin Franzke updated the commit message in patch set 3 10/02/19, 12:47

  20. Markus Klein voted on patch set 3 V +1 CR +1 10/02/19, 12:52

  21. Benjamin Franzke voted on patch set 3 V +2 CR +2 10/02/19, 12:57

  22. TYPO3com voted on patch set 3 V +1 10/02/19, 12:59 Completed build in 11m 28s on Wed, 2 Oct, 12:59 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37012

  23. Benjamin Franzke merged patch set 4 10/02/19, 13:06