Review main Abandoned

61849[BUGFIX] Do not post data on frame reload

Andreas Kienast CR 0 V 0 Easy +5 −4 updated 09/27/19, 12:59

Commit message

`NavigationContainer.reload()` and `ContentContainer.refresh()` do an
ordinary reload of the frames which causes POST data being posted again.

This patch changes the behavior to set the `src` attribute of the frames
to ensure the frame is reloaded via GET.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 59

  1. Andreas Kienast uploaded patch set 1 09/27/19, 11:49

  2. TYPO3com voted on patch set 1 V +1 09/27/19, 11:59 Completed build in 09m 56s on Fri, 27 Sep, 11:59 AM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36884

  3. Oliver Klee updated the commit message in patch set 2 09/27/19, 12:09

  4. TYPO3com voted on patch set 2 V +1 09/27/19, 12:20 Completed build in 11m 34s on Fri, 27 Sep, 12:20 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36886

  5. Andreas Kienast updated the commit message in patch set 3 09/27/19, 12:41

  6. TYPO3com voted on patch set 3 V -1 09/27/19, 12:52 Completed build in 10m 51s on Fri, 27 Sep, 12:52 PM Test Summary: 1 of 48075 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36891

  7. Frank Nägler voted on patch set 3 V +1 CR +1 09/27/19, 12:53

  8. TYPO3com voted on patch set 3 V +1 09/27/19, 12:55 Completed build in 24m 30s on Fri, 27 Sep, 12:55 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36891

  9. Andreas Kienast abandoned the change 09/27/19, 12:59

    Changes are susceptible to various edge cases, that are handled too generically.