Review main Merged

61853[BUGFIX] Add cache property to TypoScript syntax in t3editor

Tymoteusz Motylewski CR +2 V +2 Normal +158 −0 updated 03/06/20, 19:44

Commit message

Added cache type definition

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Björn Jacob +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Björn Jacob +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1118

  1. Tymoteusz Motylewski uploaded patch set 1 09/27/19, 15:31

  2. TYPO3com voted on patch set 1 V +1 09/27/19, 15:40 Completed build in 08m 47s on Fri, 27 Sep, 03:40 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36907

  3. Andrzej Kołbuc uploaded patch set 2 10/03/19, 16:28

  4. TYPO3com voted on patch set 2 V -1 10/03/19, 16:36 Completed build in 08m 12s on Thu, 3 Oct, 04:36 PM Test Summary: 47757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37030

  5. TYPO3com voted on patch set 2 V +1 10/04/19, 06:55 Completed build in 14h 35m 58s on Fri, 4 Oct, 06:55 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37030

  6. Andrzej Kołbuc uploaded patch set 3 03/03/20, 18:27

  7. TYPO3com voted on patch set 3 V -1 03/03/20, 18:37 Completed build in 10m 10s on Tue, 3 Mar, 06:37 PM Test Summary: 71819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-955

  8. TYPO3com voted on patch set 3 V +1 03/03/20, 19:34 Completed build in 1h 17m 40s on Tue, 3 Mar, 07:34 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-955

  9. Björn Jacob commented on patch set 3 03/03/20, 20:41

    tsref.xml:814

    "within the cache"

    tsref.xml:815

    Difficult to read. Very long sentence. Maybe: "Allows you to determine the lifetime of the cached object. This does not depend on the lifetime of the cached version of the page on which it is used."

    tsref.xml:816

    "." missing

    tsref.xml:823

    Would "within" be the better choise?
  10. Andrzej Kołbuc uploaded patch set 4 03/06/20, 14:38

  11. TYPO3com voted on patch set 4 V +1 03/06/20, 14:48 Completed build in 10m 29s on Fri, 6 Mar, 02:48 PM Test Summary: 72071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1034

  12. Björn Jacob commented on patch set 4 V +1 CR +1 03/06/20, 16:01

    tsref.xml:814 Reply

    Done

    tsref.xml:815 Reply

    Done

    tsref.xml:816 Reply

    Done

    tsref.xml:823 Reply

    Done
  13. Benni Mack uploaded patch set 5 03/06/20, 18:32

  14. TYPO3com voted on patch set 5 V +1 03/06/20, 18:42 Completed build in 10m 39s on Fri, 6 Mar, 06:42 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1051

  15. Benni Mack voted on patch set 5 V +1 CR +1 03/06/20, 19:18

  16. Björn Jacob voted on patch set 5 V +1 CR +1 03/06/20, 19:37

  17. Georg Ringer voted on patch set 5 V +2 CR +2 03/06/20, 19:44

  18. Georg Ringer merged patch set 6 03/06/20, 19:44