Review main Abandoned

61854[BUGFIX] Forward TSFE in order to avoid fatal error with redirects

Oliver Hader CR 0 V 0 Easy +10 −3 updated 09/28/19, 13:32

Commit message

Generating an URL for redirects handling requires some TypoScript to
be available. The regular processing relies on $GLOBALS['TSFE'] being
available - which is not the case for this scenario, earlier in the
middleware stack.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 68

  1. Oliver Hader uploaded patch set 1 09/28/19, 13:08

  2. Frank Nägler commented on patch set 1 09/28/19, 13:12

    TemplateService.php:1232

    this->frontendController is set in controller to GLOBALS[TSFE] as fallback. so not required here again.
  3. Oliver Hader commented on patch set 1 09/28/19, 13:17

    TemplateService.php:1232 Reply

    TSFE might not be set when creating an instance of this object... I'm removing TSFE from constructor
  4. TYPO3com voted on patch set 1 V -1 09/28/19, 13:17 Completed build in 09m 12s on Sat, 28 Sep, 01:17 PM Test Summary: 2944 of 48075 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36915

  5. Oliver Hader uploaded patch set 2 09/28/19, 13:18

  6. Oliver Hader commented on patch set 2 09/28/19, 13:18

    TemplateService.php:1232 Reply Unresolved

    Q.E.D. in UnitTests
  7. TYPO3com voted on patch set 2 V +1 09/28/19, 13:27 Completed build in 08m 47s on Sat, 28 Sep, 01:27 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36916

  8. Oliver Hader abandoned the change 09/28/19, 13:32