Review main Merged

61857[DOCS] Adjust path to Page TSconfig

Chris Müller CR +2 V +2 Easy +1 −1 updated 10/07/19, 11:49

Commit message

Adjust the recommended path to Page TSconfig according to
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ExtensionArchitecture/FilesAndLocations/Index.html#reserved-folders

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 914

  1. Chris Müller uploaded patch set 1 09/29/19, 14:48

  2. TYPO3com voted on patch set 1 V -1 09/29/19, 14:56 Completed build in 07m 56s on Sun, 29 Sep, 02:56 PM Test Summary: 47520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36930

  3. TYPO3com commented on patch set 1 09/29/19, 15:12 Completed build in 10m 40s on Sun, 29 Sep, 03:12 PM Test Summary: 47519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36931

  4. TYPO3com commented on patch set 1 09/29/19, 17:29 Completed build in 10m 03s on Sun, 29 Sep, 05:29 PM Test Summary: 47507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36936

  5. TYPO3com voted on patch set 1 V +1 09/29/19, 22:28 Completed build in 5h 18m 54s on Sun, 29 Sep, 10:28 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36936

  6. Oli Bartsch commented on patch set 1 CR -1 09/30/19, 09:57

    ConfigureTypo3.rst:63 Unresolved

    This should be TSconfig according to e.g. https://docs.typo3.org/m/typo3/reference-tsconfig/master/en-us/UsingSetting/Index.html#register-static-page-tsconfig-files. You can also see this naming convention in core extensions like ext:frontend or ext:backend. IMO we should also correct that in the docs you referenced.
  7. Chris Müller uploaded patch set 2 10/02/19, 17:46

  8. TYPO3com voted on patch set 2 V +1 10/02/19, 17:56 Completed build in 09m 46s on Wed, 2 Oct, 05:56 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37017

  9. Oli Bartsch commented on patch set 2 V +1 CR +1 10/02/19, 18:32

    In general I’m fine with it but would suggest to wait with merging until the docs got updated. Otherwise we still have a inconsistency. Therefore I created a PR (https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/609) today. Maybe Daniel can have a look.
  10. Jörg Bösche voted on patch set 2 CR +1 10/07/19, 10:34

  11. Steffen Frese voted on patch set 2 CR +1 10/07/19, 11:04

  12. Daniel Siepmann voted on patch set 2 V +1 CR +1 10/07/19, 11:12

  13. Frank Nägler voted on patch set 2 V +2 CR +2 10/07/19, 11:49

  14. Frank Nägler merged patch set 3 10/07/19, 11:49