61863[TASK] Unify TSconfig files and includes
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 18
- typo3/sysext/backend/ext_localconf.php+3 −1
- typo3/sysext/core/Configuration/TSconfig/Page/Tcemain.tsconfignew+1 −0
- typo3/sysext/core/ext_localconf.php4+1 −1
- typo3/sysext/felogin/Configuration/TSconfig/Page/Mod/Wizards/NewContentElement.tsconfigrenamed+0 −0
- typo3/sysext/felogin/Configuration/TSconfig/Page/PiBase/Mod/Wizards/NewContentElement.tsconfigrenamed+0 −0
- typo3/sysext/felogin/ext_localconf.php+2 −2
- typo3/sysext/form/Configuration/TSconfig/Page/Mod/Wizards/NewContentElement.tsconfigrenamed+0 −0
- typo3/sysext/form/ext_localconf.php+1 −1
- typo3/sysext/frontend/Configuration/TSconfig/User/Options.tsconfignew+9 −0
- typo3/sysext/frontend/ext_localconf.php2+5 −10
- typo3/sysext/indexed_search/Configuration/TSconfig/Page/Mod/Wizards/NewContentElement.tsconfig2new+12 −0
- typo3/sysext/indexed_search/ext_localconf.php+3 −14
- typo3/sysext/linkvalidator/Configuration/TSconfig/Page/Mod/Linkvalidator.tsconfigrenamed+0 −0
- typo3/sysext/linkvalidator/ext_localconf.php+1 −1
- typo3/sysext/recordlist/Configuration/TSconfig/Page/Tcemain.tsconfignew+36 −0
- typo3/sysext/recordlist/ext_localconf.php+3 −38
- typo3/sysext/workspaces/Configuration/TSconfig/Page/TxVersionWorkspaces.tsconfig2new+5 −0
- typo3/sysext/workspaces/ext_localconf.php+3 −5
Review log 4360
Show 2735 earlier messages
-
Oli Bartsch uploaded patch set 1 09/30/19, 11:57
-
Oli Bartsch updated the commit message in patch set 2 09/30/19, 11:59
-
Georg Ringer commented on patch set 1 CR -1 09/30/19, 11:59
sorry but this is a breaking change if files are renamed because people can use that in their site setup! -
TYPO3com voted on patch set 1 V -1 09/30/19, 12:09 Completed build in 11m 11s on Mon, 30 Sep, 12:08 PM Test Summary: 1 of 47821 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36953
-
TYPO3com voted on patch set 2 V +1 09/30/19, 12:10 Completed build in 10m 53s on Mon, 30 Sep, 12:10 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36954
-
Frank Nägler commented on patch set 2 CR -1 09/30/19, 12:12
1) I am fine with the patch in general 2) This more a TASK, not a BUGFIX 3) We should wait with this patch until 10.1 release is out on Tuesday so temporary -1 for the risk to break something shortly before our next release, -
Frank Nägler commented on patch set 2 09/30/19, 12:13
and, maybe this is breaking, should be checked in detail. someone else could include the files. -
Oli Bartsch commented on patch set 2 09/30/19, 12:26
> Patch Set 1: Code-Review-1 > > sorry but this is a breaking change if files are renamed because people can use that in their site setup! Are these files really intended to be used by others? I mean they are already included in the core or a user can add them in his template (addStaticFile). Why should somebody include them in his site setup again and add hard links to core configuration files. Is this use case somewhere documented as best practice or something? If this is not documented then using pure internals in a 3rd party extension is not considered "using public API" and thus not "breaking". -
Oli Bartsch commented on patch set 2 09/30/19, 12:28
> Patch Set 2: Code-Review-1 > > 1) I am fine with the patch in general > 2) This more a TASK, not a BUGFIX > 3) We should wait with this patch until 10.1 release is out on Tuesday > > so temporary -1 for the risk to break something shortly before our next release, I'm fine with waiting for 10.1 and will update to BUGFIX after we discussed the "breaking" topic -
Oli Bartsch commented on patch set 2 09/30/19, 12:28
> Patch Set 2: > > and, maybe this is breaking, should be checked in detail. someone else could include the files. Please see my comment on Georgs review. -
Frank Nägler commented on patch set 2 09/30/19, 12:30
> Are these files really intended to be used by others? yes :) > ... a user can add them in his template (addStaticFile). Or include all files in a template extension, which is valid and IMHO the best way to manage a site (at the moment) > Is this use case somewhere documented as best practice or something? If this is not documented then using pure internals in a 3rd party extension is not considered "using public API" and thus not "breaking". Yes, site package extension is documented or recommended in this tutorial: https://docs.typo3.org/m/typo3/tutorial-sitepackage/master/en-us/ -
Stefan P commented on patch set 2 09/30/19, 12:50
> > Is this use case somewhere documented as best practice or something? If this is not documented then using pure internals in a 3rd party extension is not considered "using public API" and thus not "breaking". > Yes, site package extension is documented or recommended in this tutorial: > https://docs.typo3.org/m/typo3/tutorial-sitepackage/master/en-us/ Where in this documentation does it say "Please include files by the core sysext's by using harcoded file paths"? Why should already auto-included files (by core ext_localconf) be included manually by people? Also this will be in the changelogs, so everybody can adjust his configuration. I can only say: people whose sites break because of including internals AND NOT reading changelogs are not the problem of TYPO3. With this argument you can reject any commit. "We can not rename this file because maybe someone does `include 'sysext/core/Some/Obscure/File.php'`" -
Georg Ringer commented on patch set 2 09/30/19, 12:54
removing my veto as those files are all icnluded by ext_localconf.php directly and @Stefan: as long as we don't have a document which is public and what is internal, we have this issue, yes -
Frank Nägler commented on patch set 2 09/30/19, 12:59
> removing my veto as those files are all icnluded by ext_localconf.php directly then I am also fine if the files are included every time by default. > and @Stefan: as long as we don't have a document which is public and what is internal, we have this issue, yes example for include typescript can be found here: https://docs.typo3.org/m/typo3/tutorial-sitepackage/master/en-us/TypoScriptConfiguration/Index.html?highlight=include_typoscript#typoscript-constants This is also possible for TSConfig files and can be adapted. But as mentioned above, if this patch contains only files, which are loaded by default, this is fine. If this patch contains files which *not* be included by default, this would be a no go. -
Oli Bartsch commented on patch set 2 09/30/19, 13:45
> Patch Set 2: > > > removing my veto as those files are all icnluded by ext_localconf.php directly > then I am also fine if the files are included every time by default. > > > and @Stefan: as long as we don't have a document which is public and what is internal, we have this issue, yes > example for include typescript can be found here: > https://docs.typo3.org/m/typo3/tutorial-sitepackage/master/en-us/TypoScriptConfiguration/Index.html?highlight=include_typoscript#typoscript-constants > > This is also possible for TSConfig files and can be adapted. > But as mentioned above, if this patch contains only files, which are loaded by default, this is fine. If this patch contains files which *not* be included by default, this would be a no go. Yes that was what I wanted to explain. All these TSconfig files get auto included by the core (ext_localconf). That’s why I didn’t understand how this can be breaking because IMO nobody should include already loaded files using hard links to these core configs. Thank you Stefan for clarifying my actual intention. I’m surely aware of adding TypoScript in the site package. That’s really a best practice and I do this in my site packages as well. But not already loaded ones especially ones loaded by the core. > I'm fine with waiting for 10.1 and will update to BUGFIX after we discussed the "breaking" topic Certainly I mean update it to be a TASK. :) -
Oliver Hader commented on patch set 2 09/30/19, 15:08
ext_localconf.php:37EXT:NewContentElement.tsconfig:11nitpick: space after := -
Oli Bartsch uploaded patch set 3 10/01/19, 13:54
-
TYPO3com voted on patch set 3 V +1 10/01/19, 14:02 Completed build in 08m 04s on Tue, 1 Oct, 02:02 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36991
-
Oli Bartsch commented on patch set 3 10/01/19, 14:05
ext_localconf.php:37ReplyDoneNewContentElement.tsconfig:11ReplyDone -
Jörg Bösche voted on patch set 3 CR +1 10/07/19, 10:36
-
Sascha Rademacher voted on patch set 3 CR +1 10/08/19, 07:47
-
Jörg Bösche voted on patch set 3 V +1 10/10/19, 12:38
-
Markus Klein commented on patch set 3 10/14/19, 11:29
To be honest, I would do that for v10 only. I see no benefit for v9 here.its -
Oli Bartsch updated the commit message in patch set 4 10/14/19, 12:36
-
Oli Bartsch commented on patch set 4 10/14/19, 12:42
> Patch Set 3: > > (1 comment) > > To be honest, I would do that for v10 only. I see no benefit for v9 here. Why is an improvement - in this case unifying code / code cleanup - no benefit? IMO every change which improves the code (quality) - not matter if it's a BUGFIX or a TASK - and is not Breaking or a Feature should be backported to versions in maintenance mode. If it’s about cost <-> benefit I could provide the backport by myself.Reply
Changed to `their` as it's plural here. -
TYPO3com voted on patch set 4 V -1 10/14/19, 12:47 Completed build in 10m 58s on Mon, 14 Oct, 12:47 PM Test Summary: 47980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37305
-
Markus Klein commented on patch set 4 10/14/19, 12:48
> Patch Set 4: > > (1 comment) > > > Patch Set 3: > > > > (1 comment) > > > > To be honest, I would do that for v10 only. I see no benefit for v9 here. > > Why is an improvement - in this case unifying code / code cleanup - no benefit? IMO every change which improves the code (quality) - not matter if it's a BUGFIX or a TASK - and is not Breaking or a Feature should be backported to versions in maintenance mode. > > If it’s about cost <-> benefit I could provide the backport by myself. Well actually technically it's a drawback as we increase file IO when extracting a few lines for TS into dedicated files. Moving things around might be nicer to read, but always has the potential for a regression, if somebody relies on a certain file for whatever reason. So why break things deliberately, if there is no real gain? The decision is up to the core team, I just expressed my thoughts on this after some years of experience as part of the former core team. -
TYPO3com commented on patch set 4 10/14/19, 13:10 Completed build in 09m 37s on Mon, 14 Oct, 01:10 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37306
-
TYPO3com voted on patch set 4 V +1 10/14/19, 13:15 Completed build in 24m 52s on Mon, 14 Oct, 01:15 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37306
-
Oli Bartsch commented on patch set 4 10/14/19, 13:25
> Patch Set 4: > > > Patch Set 4: > > > > (1 comment) > > > > > Patch Set 3: > > > > > > (1 comment) > > > > > > To be honest, I would do that for v10 only. I see no benefit for v9 here. > > > > Why is an improvement - in this case unifying code / code cleanup - no benefit? IMO every change which improves the code (quality) - not matter if it's a BUGFIX or a TASK - and is not Breaking or a Feature should be backported to versions in maintenance mode. > > > > If it’s about cost <-> benefit I could provide the backport by myself. > > Well actually technically it's a drawback as we increase file IO when extracting a few lines for TS into dedicated files. > > Moving things around might be nicer to read, but always has the potential for a regression, if somebody relies on a certain file for whatever reason. So why break things deliberately, if there is no real gain? > > The decision is up to the core team, I just expressed my thoughts on this after some years of experience as part of the former core team. Oke, I got your concern. As we previously discussed in this issue all files are not intended to be used directly by others as they are already loaded by the core. However, we should wait for feedback from the core members. -
Oli Bartsch updated the commit message in patch set 5 10/25/19, 17:24
-
Oli Bartsch commented on patch set 5 10/25/19, 17:26
> Patch Set 4: > > > Patch Set 4: > > > > (1 comment) > > > > > Patch Set 3: > > > > > > (1 comment) > > > > > > To be honest, I would do that for v10 only. I see no benefit for v9 here. > > > > Why is an improvement - in this case unifying code / code cleanup - no benefit? IMO every change which improves the code (quality) - not matter if it's a BUGFIX or a TASK - and is not Breaking or a Feature should be backported to versions in maintenance mode. > > > > If it’s about cost <-> benefit I could provide the backport by myself. > > Well actually technically it's a drawback as we increase file IO when extracting a few lines for TS into dedicated files. > > Moving things around might be nicer to read, but always has the potential for a regression, if somebody relies on a certain file for whatever reason. So why break things deliberately, if there is no real gain? > > The decision is up to the core team, I just expressed my thoughts on this after some years of experience as part of the former core team. I thought about it again and I'm with you now. I removed `9.5` so it's now only for v10. -
TYPO3com voted on patch set 5 V -1 10/25/19, 17:34 Completed build in 09m 57s on Fri, 25 Oct, 05:34 PM Test Summary: 47570 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37720
-
TYPO3com voted on patch set 5 V +1 10/25/19, 17:56 Completed build in 09m 30s on Fri, 25 Oct, 05:56 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37724
-
Alexander Stehlik commented on patch set 5 CR +1 10/27/19, 11:21
About backporting to 9.5: could be problematic for people who (for whatever reason) include the renamed files in their config. Not sure if this is a realistic scenario though ;)
-
Georg Ringer voted on patch set 5 V +1 CR +1 10/31/19, 07:50
-
Oli Bartsch uploaded patch set 6 11/17/19, 10:15
-
TYPO3com voted on patch set 6 V -1 11/17/19, 10:24 Completed build in 08m 05s on Sun, 17 Nov, 10:24 AM Test Summary: 1 of 38265 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38435
-
TYPO3com commented on patch set 6 11/17/19, 10:33 Completed build in 07m 11s on Sun, 17 Nov, 10:33 AM Test Summary: 48337 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38436
-
TYPO3com voted on patch set 6 V +1 11/18/19, 11:48 Completed build in 19m 49s on Mon, 18 Nov, 11:48 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38447
-
Alexander Stehlik voted on patch set 6 CR +1 11/18/19, 12:21
-
Georg Ringer voted on patch set 6 V +1 CR +1 11/18/19, 14:37
-
Mathias Brodala commented on patch set 6 11/23/19, 21:13
ext_localconf.php:95This must be "Tcemain.tsconfig" or all other files also follow the casing of their options.TxVersionWorkspaces.tsconfig:3Can we convert this to braced notation while we're at it? -
Oli Bartsch uploaded patch set 7 11/24/19, 17:44
-
Oli Bartsch commented on patch set 7 11/24/19, 17:45
ext_localconf.php:95ReplyDoneTxVersionWorkspaces.tsconfig:3ReplyDone -
TYPO3com voted on patch set 7 V -1 11/24/19, 17:52 Completed build in 07m 15s on Sun, 24 Nov, 05:52 PM Test Summary: 47914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38801
-
TYPO3com commented on patch set 7 11/24/19, 18:36 Completed build in 07m 06s on Sun, 24 Nov, 06:36 PM Test Summary: 37855 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38804
-
TYPO3com voted on patch set 7 V +1 11/24/19, 19:06 Completed build in 06m 58s on Sun, 24 Nov, 07:06 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38805
-
Jörg Bösche voted on patch set 7 CR +1 11/25/19, 15:39
-
Alexander Stehlik voted on patch set 7 CR +1 11/26/19, 22:37
-
Oli Bartsch uploaded patch set 8 11/28/19, 22:04
-
Oli Bartsch uploaded patch set 9 11/28/19, 22:08
-
TYPO3com voted on patch set 8 V +1 11/28/19, 22:41 Completed build in 14m 14s on Thu, 28 Nov, 10:41 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38906
-
TYPO3com voted on patch set 9 V +1 11/28/19, 22:48 Completed build in 21m 22s on Thu, 28 Nov, 10:48 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38907
-
Henning Liebe voted on patch set 9 CR +1 01/14/20, 11:47
-
Markus Klein commented on patch set 9 CR -1 01/14/20, 21:36
ext_localconf.php:82I still see absolutely no benefit in such a change. We only add filesystem I/O for absolutely no gain. -
Oli Bartsch uploaded patch set 10 01/31/20, 17:15
-
Oli Bartsch commented on patch set 10 01/31/20, 17:16
ext_localconf.php:82Reply UnresolvedThe benefit is unifying the whole TSconfig in the core. The problem I see is that documentation currently doesn't match the implementation in the core. This caused much confusion in the past. That was the reason why I initially created this patch. The way TSconfig is done or better should be done varies from documentation to documentation and from sysext to sysext. So why not fixing this now once and for all? -
TYPO3com voted on patch set 10 V +1 01/31/20, 17:31 Completed build in 11m 59s on Fri, 31 Jan, 05:31 PM Test Summary: 71182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40438
-
Oli Bartsch abandoned the change 02/22/20, 00:06
Because of the I/O this patch produces just the import syntax will be changed. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63363