61864[BUGFIX] Streamline site configuration import in distribution packages
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1419
-
Oliver Hader uploaded patch set 1 09/30/19, 12:31
-
Oliver Hader commented on patch set 1 09/30/19, 12:35
-
TYPO3com voted on patch set 1 V -1 09/30/19, 12:55 Completed build in 15m 04s on Mon, 30 Sep, 12:55 PM Test Summary: 8 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36957
-
Oliver Klee commented on patch set 1 09/30/19, 13:43
SiteConfiguration.php:125UnresolvedI propose to avoid the implicit negation and instead use a variable $useCache with a default of true. This will help make the code more straightforward, reducing the probability of people misreading it. -
Andreas Kienast uploaded patch set 2 09/30/19, 14:23
-
TYPO3com voted on patch set 2 V +1 09/30/19, 14:34 Completed build in 10m 56s on Mon, 30 Sep, 02:34 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36959
-
Andreas Kienast uploaded patch set 3 09/30/19, 15:50
-
Andreas Kienast voted on patch set 3 CR +1 09/30/19, 15:50
-
TYPO3com voted on patch set 3 V +1 09/30/19, 16:01 Completed build in 10m 07s on Mon, 30 Sep, 04:01 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36962
-
Guido Schmechel commented on patch set 3 09/30/19, 16:46
InstallUtility.php:640That could be $destinationFolder? -
Andreas Kienast uploaded patch set 4 09/30/19, 17:29
-
Andreas Kienast voted on patch set 4 CR +1 09/30/19, 17:29
-
TYPO3com voted on patch set 4 V -1 09/30/19, 17:38 Completed build in 08m 10s on Mon, 30 Sep, 05:38 PM Test Summary: 47508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36964
-
TYPO3com voted on patch set 4 V +1 09/30/19, 17:47 Completed build in 26m 12s on Mon, 30 Sep, 05:47 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36964
-
Andreas Kienast voted on patch set 4 V +1 09/30/19, 18:00
-
Oliver Hader voted on patch set 4 V +2 CR +2 09/30/19, 18:50
-
Oliver Hader merged patch set 5 09/30/19, 18:50
-
Oliver Hader commented on patch set 5 09/30/19, 20:30
InstallUtility.php:640ReplyYes, I discovered too late... -
Guido Schmechel commented on patch set 5 10/01/19, 07:07
InstallUtility.php:640Reply UnresolvedAndreas fixed it in Patchset 4.
InstallUtility.php:627Unresolved