Review main Merged

61864[BUGFIX] Streamline site configuration import in distribution packages

Oliver Hader CR +2 V +2 Normal +121 −31 updated 10/01/19, 07:07

Commit message

Site configuration shipped in distribution packages had a couple of flaws
during import process which are tackled with this change:

* existing site configurations for same identifier are not overridden on
  the file system level anymore (according warning is logged)
* site configuration is now updated and mapped to for imported pages,
  which did not work before due to hard-coded rootPageId in config.yaml
  (warning is logged in case root page id cannot be mapped)

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1419

  1. Oliver Hader uploaded patch set 1 09/30/19, 12:31

  2. Oliver Hader commented on patch set 1 09/30/19, 12:35

    InstallUtility.php:627 Unresolved

    The whole method (and class) is bad software design... I just focussed on the obvious bugs...
  3. TYPO3com voted on patch set 1 V -1 09/30/19, 12:55 Completed build in 15m 04s on Mon, 30 Sep, 12:55 PM Test Summary: 8 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36957

  4. Oliver Klee commented on patch set 1 09/30/19, 13:43

    SiteConfiguration.php:125 Unresolved

    I propose to avoid the implicit negation and instead use a variable $useCache with a default of true. This will help make the code more straightforward, reducing the probability of people misreading it.
  5. Andreas Kienast uploaded patch set 2 09/30/19, 14:23

  6. TYPO3com voted on patch set 2 V +1 09/30/19, 14:34 Completed build in 10m 56s on Mon, 30 Sep, 02:34 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36959

  7. Andreas Kienast uploaded patch set 3 09/30/19, 15:50

  8. Andreas Kienast voted on patch set 3 CR +1 09/30/19, 15:50

  9. TYPO3com voted on patch set 3 V +1 09/30/19, 16:01 Completed build in 10m 07s on Mon, 30 Sep, 04:01 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36962

  10. Guido Schmechel commented on patch set 3 09/30/19, 16:46

    InstallUtility.php:640

    That could be $destinationFolder?
  11. Andreas Kienast uploaded patch set 4 09/30/19, 17:29

  12. Andreas Kienast voted on patch set 4 CR +1 09/30/19, 17:29

  13. TYPO3com voted on patch set 4 V -1 09/30/19, 17:38 Completed build in 08m 10s on Mon, 30 Sep, 05:38 PM Test Summary: 47508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36964

  14. TYPO3com voted on patch set 4 V +1 09/30/19, 17:47 Completed build in 26m 12s on Mon, 30 Sep, 05:47 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36964

  15. Andreas Kienast voted on patch set 4 V +1 09/30/19, 18:00

  16. Oliver Hader voted on patch set 4 V +2 CR +2 09/30/19, 18:50

  17. Oliver Hader merged patch set 5 09/30/19, 18:50

  18. Oliver Hader commented on patch set 5 09/30/19, 20:30

    InstallUtility.php:640 Reply

    Yes, I discovered too late...
  19. Guido Schmechel commented on patch set 5 10/01/19, 07:07

    InstallUtility.php:640 Reply Unresolved

    Andreas fixed it in Patchset 4.