Review main Merged

61865[BUGFIX] Re-implement record deletion via EditDocumentController

Andreas Kienast CR +2 V +2 Easy +20 −11 updated 09/30/19, 18:50

Commit message

The change of #89033 removed the callback for deleting records within
EditDocumentController, resulting in JavaScript errors.

This patch adds the delete action again, directly implemented in the
FormEngine module. The URL to delete the record is pre-built as well,
since any required information is already known.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 09/30/19, 15:43

  2. Andreas Kienast uploaded patch set 2 09/30/19, 15:45

  3. TYPO3com voted on patch set 1 V -1 09/30/19, 15:56 Completed build in 12m 03s on Mon, 30 Sep, 03:56 PM Test Summary: 1 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36960

  4. TYPO3com voted on patch set 2 V +1 09/30/19, 15:58 Completed build in 12m 56s on Mon, 30 Sep, 03:58 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36961

  5. Oliver Hader voted on patch set 2 V +1 CR +1 09/30/19, 16:55

  6. Georg Ringer commented on patch set 2 09/30/19, 18:38

    EditDocumentController.php:1601 Unresolved

    no need for that line, phpstorm knows that already if properly configured
  7. Oliver Hader voted on patch set 2 V +2 CR +2 09/30/19, 18:49

  8. Oliver Hader merged patch set 3 09/30/19, 18:50