Review main Merged

61866[BUGFIX] Pass SiteFinder to RedirectService instance

Andreas Kienast CR +2 V +2 Easy +3 −2 updated 09/30/19, 17:40

Commit message

The patch for #89317 extended the RedirectService, but didn't adjust all
constructors. In this case, IntegrityService was forgotten and didn't
pass a SiteFinder to the RedirectService.

This patch now passes the SiteFinder instance.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 57

  1. Andreas Kienast uploaded patch set 1 09/30/19, 17:24

  2. Oliver Hader voted on patch set 1 CR +1 09/30/19, 17:26

  3. TYPO3com voted on patch set 1 V -1 09/30/19, 17:33 Completed build in 09m 06s on Mon, 30 Sep, 05:33 PM Test Summary: 47752 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36963

  4. Benjamin Kott voted on patch set 1 V +1 CR +1 09/30/19, 17:35

  5. TYPO3com voted on patch set 1 V +1 09/30/19, 17:36 Completed build in 21m 29s on Mon, 30 Sep, 05:36 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36963

  6. Oliver Hader voted on patch set 1 V +2 CR +2 09/30/19, 17:40

  7. Oliver Hader merged patch set 2 09/30/19, 17:40