Review main Merged

61867[TASK] Use attribute translate="no" for non translatable strings

Georg Ringer CR +2 V +2 Easy +16 −16 updated 03/04/20, 07:10

Commit message

If a string is used in a XLIFF file but it should not be translated,
it must be identified as such. The XLIFF standard provides the attribute
"translate", see
http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#translate.

The big advantage is that translators on Crowdin don't even see those labels anymore.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2026

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 10/01/19, 02:20

  1. Georg Ringer commented on patch set 1 10/01/19, 02:21

    This change is ready for review.
  2. TYPO3com voted on patch set 1 V +1 10/01/19, 02:29 Completed build in 08m 54s on Tue, 1 Oct, 02:29 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36975

  3. Björn Jacob voted on patch set 1 V +1 CR +1 10/01/19, 04:44

  4. Markus Klein commented on patch set 1 CR -1 10/01/19, 09:44

    locallang_mod_file_list.xlf:73

    why is this not translatable? I think this is translated to S in DE
  5. Georg Ringer commented on patch set 1 10/01/19, 11:12

    locallang_mod_file_list.xlf:73 Reply

    IMO we are using this one line char we shouldn't translate that and keep the technical R/W but would like to see a longer text for non techies
  6. Markus Klein commented on patch set 1 10/01/19, 11:35

    locallang_mod_file_list.xlf:73 Reply Unresolved

    What speaks against translation to L/S? Besides that a tooltip on the chars can hold the full text
  7. Georg Ringer commented on patch set 1 10/01/19, 11:45

    deal ;) will remove this file from patchset
  8. Georg Ringer uploaded patch set 2 10/02/19, 03:40

  9. TYPO3com voted on patch set 2 V -1 10/02/19, 03:50 Completed build in 10m 17s on Wed, 2 Oct, 03:50 AM Test Summary: 2 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36992

  10. TYPO3com voted on patch set 2 V +1 10/02/19, 04:35 Completed build in 1h 05m 18s on Wed, 2 Oct, 04:35 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36992

  11. Markus Klein commented on patch set 2 10/02/19, 08:08

    Dumb question: Why do we put things into labels, if we don't want things to be translated. We can put it right into the code as well then. Especially things like a dash.
  12. Benni Mack commented on patch set 2 01/15/20, 11:40

    ping
  13. Daniel Goerz commented on patch set 2 01/25/20, 09:49

    > Patch Set 2: > > Dumb question: Why do we put things into labels, if we don't want things to be translated. We can put it right into the code as well then. Especially things like a dash. +1
  14. Georg Ringer commented on patch set 2 02/27/20, 11:37

    > Patch Set 2: > > > Patch Set 2: > > > > Dumb question: Why do we put things into labels, if we don't want things to be translated. We can put it right into the code as well then. Especially things like a dash. > > +1 The reasons are fairly simple. Regarding belog: there are not only numbers but also labels, see ---- selectableNumberOfLogEntries { 20 = 20 50 = 50 100 = 100 200 = 200 500 = 500 1000 = 1000 1000000 = any ----- which then checks for translations. Regarding crop ratio. check out this example ---- '16:9' => [ 'title' => 'LLL:EXT:core/Resources/Private/Language/locallang_wizards.xlf:imwizard.ratio.16_9', 'value' => 1.777777777777777 ], ---- yes of course we just could put the '16:9' into the TCA but 1st this is also ugly and 2nd and more important this is then not consistent anymore to any other label and for other crop ratios people could use and where there is actual text in it. having 16:9 as label would be consistent .
  15. Georg Ringer uploaded patch set 3 02/27/20, 13:17

  16. TYPO3com voted on patch set 3 V -1 02/27/20, 13:32 Completed build in 14m 11s on Thu, 27 Feb, 01:32 PM Test Summary: 1 of 72481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-737

  17. Georg Ringer rebased onto patch set 4 02/27/20, 13:48

  18. TYPO3com voted on patch set 4 V +1 02/27/20, 13:59 Completed build in 10m 37s on Thu, 27 Feb, 01:59 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-738

  19. Georg Ringer updated the commit message in patch set 5 02/27/20, 14:14

  20. TYPO3com voted on patch set 5 V +1 02/27/20, 14:25 Completed build in 10m 58s on Thu, 27 Feb, 02:25 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-741

  21. Oli Bartsch commented on patch set 5 02/27/20, 15:36

    > Patch Set 2: > > > Patch Set 2: > > > > > Patch Set 2: > > > > > > Dumb question: Why do we put things into labels, if we don't want things to be translated. We can put it right into the code as well then. Especially things like a dash. > > > > +1 > > The reasons are fairly simple. > Regarding belog: there are not only numbers but also labels, see > ---- > selectableNumberOfLogEntries { > 20 = 20 > 50 = 50 > 100 = 100 > 200 = 200 > 500 = 500 > 1000 = 1000 > 1000000 = any > ----- > > which then checks for translations. > > Regarding crop ratio. check out this example > ---- > '16:9' => [ > 'title' => 'LLL:EXT:core/Resources/Private/Language/locallang_wizards.xlf:imwizard.ratio.16_9', > 'value' => 1.777777777777777 > ], > ---- > > yes of course we just could put the '16:9' into the TCA but 1st this is also ugly and 2nd and more important this is then not consistent anymore to any other label and for other crop ratios people could use and where there is actual text in it. having 16:9 as label would be consistent . I think there can't be a general rule. It always depends on the use case. See the examples here. Like Georg showed there are places where it's quite not possible to use static text because it is mixed with labels. Furthermore I personally think consistency in TCA is really important to keep it maintainable. This can also apply to templates. We often - see here the "TYPO3" labels - put the companies` name also in a label just to have all texts displayed on the website at one central place. Otherwise one can never be sure where to search for labels.
  22. Benni Mack voted on patch set 5 V +1 CR +1 02/28/20, 14:23

  23. Daniel Goerz voted on patch set 5 CR +1 02/28/20, 14:24

  24. Susi Moog voted on patch set 5 V +2 CR +2 03/04/20, 07:10

  25. Susi Moog merged patch set 6 03/04/20, 07:10