Review main Merged

61872[TASK] Deprecate legacy FormEngine functions

Andreas Kienast CR +2 V +2 Hard +281 −137 updated 10/07/19, 07:47

Commit message

This patch deprecates the last remaining legacy functions in FormEngine:

- setFormValueOpenBrowser()
- setFormValueFromBrowseWin()
- setHiddenFromList()
- setFormValueManipulate()
- setFormValue_getFObj()

Additionally, a call to the undefined function `group_change` has been
removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1323

  1. Andreas Kienast uploaded patch set 1 10/02/19, 06:26

  2. TYPO3com voted on patch set 1 V +1 10/02/19, 06:43 Completed build in 10m 56s on Wed, 2 Oct, 06:43 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36993

  3. Andreas Kienast uploaded patch set 2 10/02/19, 07:46

  4. TYPO3com voted on patch set 2 V -1 10/02/19, 07:57 Completed build in 10m 16s on Wed, 2 Oct, 07:57 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36997

  5. Andreas Kienast uploaded patch set 3 10/02/19, 08:48

  6. TYPO3com voted on patch set 3 V +1 10/02/19, 09:01 Completed build in 12m 40s on Wed, 2 Oct, 09:01 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37000

  7. Andreas Kienast uploaded patch set 4 10/02/19, 09:05

  8. TYPO3com voted on patch set 4 V -1 10/02/19, 09:17 Completed build in 11m 16s on Wed, 2 Oct, 09:17 AM Test Summary: 1 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37001

  9. Andreas Kienast uploaded patch set 5 10/02/19, 09:39

  10. TYPO3com voted on patch set 5 V +1 10/02/19, 09:48 Completed build in 08m 51s on Wed, 2 Oct, 09:48 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37003

  11. Andreas Kienast uploaded patch set 6 10/02/19, 10:06

  12. Andreas Kienast uploaded patch set 7 10/02/19, 10:07

  13. TYPO3com voted on patch set 6 V +1 10/02/19, 10:17 Completed build in 10m 19s on Wed, 2 Oct, 10:17 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37005

  14. TYPO3com voted on patch set 7 V +1 10/02/19, 10:21 Completed build in 13m 15s on Wed, 2 Oct, 10:21 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37006

  15. Frank Nägler voted on patch set 7 CR +1 10/02/19, 10:59

  16. Andreas Kienast uploaded patch set 8 10/02/19, 11:13

  17. TYPO3com voted on patch set 8 V +1 10/02/19, 11:24 Completed build in 10m 31s on Wed, 2 Oct, 11:24 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37007

  18. Andreas Kienast uploaded patch set 9 10/07/19, 07:11

  19. Frank Nägler voted on patch set 9 V +1 CR +1 10/07/19, 07:13

  20. TYPO3com voted on patch set 9 V -1 10/07/19, 07:21 Completed build in 09m 49s on Mon, 7 Oct, 07:21 AM Test Summary: 1 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37075

  21. TYPO3com voted on patch set 9 V +1 10/07/19, 07:34 Completed build in 33m 01s on Mon, 7 Oct, 07:34 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37075

  22. Georg Ringer voted on patch set 9 V +2 CR +2 10/07/19, 07:47

  23. Georg Ringer merged patch set 10 10/07/19, 07:47