Review main Merged

61877[TASK] Fill original attribute properly

Georg Ringer CR +2 V +2 Hard +167 −167 updated 10/04/19, 11:07

Commit message

The attribute original should be filled with a useful information
instead of dummy value "messages".

This string is also shown in Crowdin and helps users while translating.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 167

Show 147 more files

Review log 910

  1. Georg Ringer uploaded patch set 1 10/03/19, 07:03

  2. Georg Ringer commented on patch set 1 10/03/19, 07:04

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 10/03/19, 07:11 Completed build in 08m 03s on Thu, 3 Oct, 07:11 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37024

  4. Markus Klein voted on patch set 1 V +1 CR +1 10/03/19, 08:24

  5. Benjamin Franzke commented on patch set 1 10/03/19, 08:54

    about.xlf:3 Unresolved

    We've got some redundancy here. EXT:about is already coded into the product-name (as typo3-cms-about). Additionally it's not really a file name (after all, EXT: is no "official protocol"). Question regarding crowdin: Will crowdin display the "product-name" attribute value additional to the "original" property? In that case it would be an option to use Resources/Private/Language/Modules/about.xlf, or even 'Modules/about.xlf'. I would additionally prefer "Resources/Private/Language/Modules/about.xlf" because the "original" attribute is then the "correct" value when you look at the subtree-split packages.
  6. Georg Ringer commented on patch set 1 10/03/19, 09:21

    The attribute "product-name" is nothing official and is not supported by Crowdin. As soon as Crowdin is officially used I will remove this property. I know that "EXT..." is no valid file name but this is also not required. As regular extensions will also use Crowdin we should come up with something which works for everything. The subtree split won't be used by Crowdin but we have there TYPO3 as full package. The exported translations are later of course independent
  7. Benjamin Franzke commented on patch set 1 10/03/19, 09:34

    > The attribute "product-name" is nothing official and is not supported by Crowdin. As soon as Crowdin is officially used I will remove this property. Why? It's part of the xliff standard: http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#product-name > I know that "EXT..." is no valid file name but this is also not required. As regular extensions will also use Crowdin we should come up with something which works for everything. Yes, I agree and therefore I thought we should handle sysexts like every other extension and define the path relative to the extension (product). So maybe crowdin should learn about the official product-name property: http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#product-name If that's by no means possible, yes, then it seems we need to prefix EXT:.. But I hope that crowdin is a bit flexible here – I mean, after all, the promise was that crowdin is willing to add features/adapt for TYPO3. (And I don't ask for rare-cases here, just the property from the xliff-spec). > The subtree split won't be used by Crowdin but we have there TYPO3 as full package. The exported translations are later of course independent Right, still it's good to have the subtree packages self-contained. Like we also want to have proper dependencies for all depndencies of a sysext in the composer.json (in future), the Language files should be self-contained as well. That crowdin dooes not use the subtree split packages but the root repository is just an implementation detail IMO.
  8. Georg Ringer commented on patch set 1 10/03/19, 09:44

    > Yes, I agree and therefore I thought we should handle sysexts like every other extension and define the path relative to the extension (product). If you translate across multiple projects it is nice to see which file you are actually handling. > But I hope that crowdin is a bit flexible here – I mean, after all, the promise was that crowdin is willing to add features/adapt for TYPO3. (And I don't ask for rare-cases here, just the property from the xliff-spec). Nevertheless I would like to get rid of the static text "messages" which doesn't help at all. So this needs to be replaced anyway - the only real question is with what. > Right, still it's good to have the subtree packages self-contained. Like we also want to have proper dependencies for all depndencies of a sysext in the composer.json (in future), the Language files should be self-contained as well. the exported language files are self-contained as well.
  9. Andreas Kienast voted on patch set 1 V +2 CR +2 10/04/19, 11:07

  10. Andreas Kienast merged patch set 2 10/04/19, 11:07