61880[BUGFIX] Allow control fields to be null when a query spans several tables
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 22
- typo3/sysext/core/Classes/Database/Query/Restriction/AbstractRestrictionContainer.php+11 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/BackendWorkspaceRestriction.php+30 −6
- typo3/sysext/core/Classes/Database/Query/Restriction/DeletedRestriction.php1+16 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/DocumentTypeExclusionRestriction.php+13 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/EndTimeRestriction.php+13 −4
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php+1 −0
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php+32 −4
- typo3/sysext/core/Classes/Database/Query/Restriction/HiddenRestriction.php+16 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/JoinAwareRestrictionInterface.phpnew+44 −0
- typo3/sysext/core/Classes/Database/Query/Restriction/JoinAwareRestrictionTrait.phpnew+60 −0
- typo3/sysext/core/Classes/Database/Query/Restriction/RootLevelRestriction.php+13 −2
- typo3/sysext/core/Classes/Database/Query/Restriction/StartTimeRestriction.php+16 −3
- typo3/sysext/core/Classes/Database/Query/Restriction/WorkspaceRestriction.php+17 −2
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+9 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-88919-AddJoinAwareRestrictionInterface.rstnew+26 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/BackendWorkspaceRestrictionTest.php+68 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DeletedRestrictionTest.php+17 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/EndTimeRestrictionTest.php+23 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+72 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/HiddenRestrictionTest.php+21 −0
Review log 1419
-
Georg Großberger uploaded patch set 1 10/03/19, 17:34
-
TYPO3com voted on patch set 1 V -1 10/03/19, 17:44 Completed build in 10m 00s on Thu, 3 Oct, 05:44 PM Test Summary: 8 of 48134 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37031
-
Stefan P commented on patch set 1 10/07/19, 05:15
-
Susi Moog commented on patch set 1 10/26/19, 09:07
Can you please add/adjust the tests to document this new behaviour? -
Georg Großberger uploaded patch set 2 01/04/20, 16:48
-
TYPO3com voted on patch set 2 V -1 01/04/20, 16:49 Completed build in 13s on Sat, 4 Jan, 04:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39703
-
Georg Großberger uploaded patch set 3 01/04/20, 16:58
-
TYPO3com voted on patch set 3 V -1 01/04/20, 17:05 Completed build in 07m 25s on Sat, 4 Jan, 05:05 PM Test Summary: 3178 of 69592 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39704
-
Tymoteusz Motylewski commented on patch set 3 01/04/20, 22:28
Hi nice finding! How can it be tested? Do you a case in the Core where the issue can be observed? -
Manuel Selbach wrote 03/30/20, 19:49
Topic set to persistence -
Benni Mack commented on patch set 3 04/13/20, 10:22
Have you checked this alternative? https://review.typo3.org/c/Packages/TYPO3.CMS/+/60781/ -
Georg Großberger uploaded patch set 4 04/15/20, 07:31
-
Georg Großberger commented on patch set 4 04/15/20, 07:44
> Patch Set 3: > > Hi nice finding! > How can it be tested? Do you a case in the Core where the issue can be observed? I don't know about a place in the core where this is used, but I had it in a couple projects. A very simple use case would be this: get the title of an optionally selected category. $qb->select('p.title', 'c.title AS category'); $qb->from('products', 'p'); $qb->leftJoin('p', 'category', 'c', 'p.category = c.uid'); With this patch, category is NULL if no category is selected. Without it, no row would be returned. -
Georg Großberger commented on patch set 4 04/15/20, 07:47
> Patch Set 3: > > Have you checked this alternative? https://review.typo3.org/c/Packages/TYPO3.CMS/+/60781/ I checked, but while they can be used to archive the same, they do not provide the same. The main difference is, that this patch automatically adds nullable restrictions, while the other strips all restrictions from the selected tables, and that must be done manually. IMHO both are valid and not exclusive. -
TYPO3com voted on patch set 4 V -1 04/15/20, 07:52 Completed build in 20m 30s on Wed, 15 Apr, 07:52 AM Test Summary: 4541 of 73989 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2549
-
Georg Großberger uploaded patch set 5 04/15/20, 08:27
-
TYPO3com voted on patch set 5 V -1 04/15/20, 08:40 Completed build in 12m 45s on Wed, 15 Apr, 08:40 AM Test Summary: 3899 of 73989 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2556
-
Georg Großberger abandoned the change 04/16/20, 06:16
Succeeded by 60781 -
Markus Klein commented on patch set 5 06/25/20, 07:16
IMO the related patch this one was abandoned for does not resolve this bug.
DeletedRestriction.php:46Unresolved