Review main Merged

61881[FEATURE] Add "storeSession" argument to Widget ViewHelpers

Christian Eßl CR +2 V +2 Normal +59 −1 updated 10/17/19, 13:37

Commit message

Widget ViewHelpers, by default, can store the widgets session in the
database by utilizing a cookie. In frontend context this
would automatically create a "fe_typo_user" cookie when, for instance,
the <f:widget.autocomplete> ViewHelper is used.

As this is not always a desired behaviour (gdpr), a boolean argument
"storeSession" is added to AbstractWidgetViewHelper, which defaults to
true and can be used to the disable session storage for this ViewHelper.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2029

Show 34 earlier messages
  1. Christian Eßl uploaded patch set 1 10/03/19, 20:10

  2. TYPO3com voted on patch set 1 V -1 10/03/19, 20:20 Completed build in 09m 54s on Thu, 3 Oct, 08:20 PM Test Summary: 4 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37032

  3. Oli Bartsch commented on patch set 1 10/04/19, 07:17

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:17

    argument

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:19

    Without the "the".

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:31

    You could think about adding a "needs" here for improving the readability.

    AbstractWidgetViewHelper.php:107

    Please remove the whitesapce.
  4. Christian Eßl commented on patch set 1 10/04/19, 12:05

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:17 Reply

    Done

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:19 Reply

    Done

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:31 Reply

    Done

    AbstractWidgetViewHelper.php:107 Reply

    Done
  1. Christian Eßl uploaded patch set 2 10/04/19, 12:08

  2. Christian Eßl uploaded patch set 3 10/04/19, 12:14

  3. TYPO3com voted on patch set 2 V -1 10/04/19, 12:19 Completed build in 11m 07s on Fri, 4 Oct, 12:19 PM Test Summary: 4 of 48118 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37043

  4. TYPO3com voted on patch set 3 V +1 10/04/19, 12:24 Completed build in 09m 52s on Fri, 4 Oct, 12:24 PM Test Summary: 47761 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37044

  5. Daniel Siepmann uploaded patch set 4 10/07/19, 10:15

  6. Daniel Siepmann voted on patch set 4 CR +1 10/07/19, 10:15

  7. Oli Bartsch voted on patch set 4 CR +1 10/07/19, 10:25

  8. TYPO3com voted on patch set 4 V -1 10/07/19, 10:37 Completed build in 22m 31s on Mon, 7 Oct, 10:37 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37091

  9. Andreas Kienast rebased onto patch set 5 10/07/19, 10:38

  10. TYPO3com voted on patch set 5 V +1 10/07/19, 11:18 Completed build in 20m 06s on Mon, 7 Oct, 11:18 AM Test Summary: 47723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37095

  11. Oli Bartsch voted on patch set 5 CR +1 10/07/19, 16:42

  12. Markus Klein commented on patch set 5 10/11/19, 13:45

    Unresolved

    a boolean ... IS added commit messages must be imperative present tense.
  13. Markus Klein updated the commit message in patch set 6 10/11/19, 13:45

  14. Markus Klein voted on patch set 6 CR +1 10/11/19, 13:46

  15. TYPO3com voted on patch set 6 V +1 10/11/19, 13:55 Completed build in 10m 11s on Fri, 11 Oct, 01:55 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37264

  16. Georg Ringer commented on patch set 6 CR -1 10/12/19, 04:52

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:18 Unresolved

    has been

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:23 Unresolved

    use .. code-block:: html, also below

    Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst:32 Unresolved

    The default value of the property `storeSession` is set to `true`.
  17. Christian Eßl uploaded patch set 7 10/12/19, 13:39

  18. TYPO3com voted on patch set 7 V -1 10/12/19, 13:53 Completed build in 13m 59s on Sat, 12 Oct, 01:53 PM Test Summary: 1 of 48345 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37288

  19. TYPO3com commented on patch set 7 10/12/19, 15:51 Completed build in 09m 49s on Sat, 12 Oct, 03:51 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37289

  20. TYPO3com voted on patch set 7 V +1 10/14/19, 16:00 Completed build in 12m 13s on Mon, 14 Oct, 04:00 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37321

  21. Oli Bartsch voted on patch set 7 CR +1 10/16/19, 09:21

  22. Oli Bartsch voted on patch set 7 V +1 10/17/19, 13:00

  23. Frank Nägler voted on patch set 7 CR +1 10/17/19, 13:01

  24. Frank Nägler voted on patch set 7 V +2 CR +2 10/17/19, 13:37

  25. Frank Nägler merged patch set 8 10/17/19, 13:37