Review main Merged

61882[BUGFIX] Fix TypeScript path in Grunt watcher

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 10/06/19, 20:32

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Andreas Kienast uploaded patch set 1 10/04/19, 07:39

  2. TYPO3com voted on patch set 1 V +1 10/04/19, 07:49 Completed build in 09m 34s on Fri, 4 Oct, 07:49 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37034

  3. Oli Bartsch commented on patch set 1 10/04/19, 08:41

    Gruntfile.js:208

    Shouldn't we use '<%= paths.typescript %>**/*.ts' here?
  4. Andreas Kienast commented on patch set 1 10/04/19, 08:48

    Gruntfile.js:208 Reply

    Good catch. Can you please update and test the patch? I'm in the middle of something.
  5. Oli Bartsch uploaded patch set 2 10/04/19, 09:17

  6. Andreas Kienast uploaded patch set 3 10/04/19, 09:17

  7. Oli Bartsch commented on patch set 3 V +1 CR +1 10/04/19, 09:19

    Gruntfile.js:208 Reply Unresolved

    Our commits overlapped each other.
  8. TYPO3com voted on patch set 2 V +1 10/04/19, 09:33 Completed build in 13m 19s on Fri, 4 Oct, 09:33 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37039

  9. TYPO3com voted on patch set 3 V +1 10/04/19, 09:35 Completed build in 15m 20s on Fri, 4 Oct, 09:35 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37040

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 10/06/19, 20:32

  11. Daniel Goerz merged patch set 4 10/06/19, 20:32