Review main Merged

61885[BUGFIX] Fix /date|time|int/ regex in backend search

Christian Eßl CR +2 V +2 Easy +7 −7 updated 12/27/19, 22:17

Commit message

Several parts of the core use the regular expression /date|time|int/ to
test, if an 'eval' TCA configuration of a field contains one of these
evaluation strings. This regex would however match any other string that
contains one of those words. This patch fixes this behaviour by matching
only the exact words.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 710

  1. Christian Eßl uploaded patch set 1 10/04/19, 14:18

  2. TYPO3com voted on patch set 1 V +1 10/04/19, 14:30 Completed build in 11m 26s on Fri, 4 Oct, 02:30 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37047

  3. Christoph Lehmann commented on patch set 1 CR -1 10/06/19, 19:38

    LiveSearch.php:340 Unresolved

    ?: makes no difference
  4. Christian Eßl updated the commit message in patch set 2 10/15/19, 11:41

  5. TYPO3com voted on patch set 2 V -1 10/15/19, 11:46 Completed build in 19s on Tue, 15 Oct, 11:46 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37334

  6. Benni Mack uploaded patch set 3 12/27/19, 21:13

  7. Oliver Hader voted on patch set 3 V +1 CR +1 12/27/19, 21:18

  8. TYPO3com voted on patch set 3 V +1 12/27/19, 22:05 Completed build in 35m 27s on Fri, 27 Dec, 10:05 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39621

  9. Benni Mack voted on patch set 3 V +2 CR +2 12/27/19, 22:17

  10. Benni Mack merged patch set 4 12/27/19, 22:17