Review main Merged

61890[BUGFIX] Substitute form references for array keys as well in ext:form

Christian Eßl CR +2 V +2 Normal +45 −6 updated 11/06/20, 10:41

Commit message

In ext:form, string placeholders, like "{text-1}", can be used inside
the finisher to place form inputs, made by the user, inside fields like
the email subject, reploy to email and name, etc. These string
substitutions however were not done for array keys (only array values).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Mathias Brodala +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Eßl uploaded patch set 1 10/05/19, 08:43

  2. TYPO3com voted on patch set 1 V +1 10/05/19, 08:53 Completed build in 09m 50s on Sat, 5 Oct, 08:53 AM Test Summary: 47763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37055

  3. Susi Moog voted on patch set 1 CR +1 10/09/19, 11:09

  4. Susi Moog voted on patch set 1 V +1 11/09/19, 12:33

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 11/09/19, 13:04

  6. Daniel Goerz merged patch set 2 11/09/19, 13:04

  7. Mathias Brodala commented on patch set 2 V +1 CR +1 11/06/20, 10:41

    Thanks. :-)