Review main Merged

61891[BUGFIX] Show form definitions with same filename from different storages

Christian Eßl CR +2 V +2 Easy +2 −2 updated 11/22/19, 19:19

Commit message

If multiple storages for form definitions exist and two or more storages
have form definitions with the same filename, the latter form definition
would not be shown in the list of the form manager.

The patch fixes this problem.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Susi Moog +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2227

Show 12 earlier messages
  1. Christian Eßl uploaded patch set 1 10/05/19, 09:02

  2. TYPO3com voted on patch set 1 V -1 10/05/19, 09:02 Completed build in 11s on Sat, 5 Oct, 09:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37056

  1. Christian Eßl uploaded patch set 2 10/05/19, 09:13

  2. TYPO3com voted on patch set 2 V +1 10/05/19, 09:23 Completed build in 09m 58s on Sat, 5 Oct, 09:23 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37057

  3. Mathias Brodala commented on patch set 2 10/07/19, 06:54

    FormPersistenceManager.php:368

    What if this also already exists? I'd rather append a random string here.
  4. Christian Eßl commented on patch set 2 10/07/19, 07:03

    FormPersistenceManager.php:368 Reply

    I made it behave exactly the same as in getFilesInFolder(): (which is called from FormPersistenceManager) https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Resource/ResourceStorage.php#L1547 It will append 'z' until the $key is unique.
  5. Mathias Brodala commented on patch set 2 10/07/19, 07:05

    FormPersistenceManager.php:368 Reply

    Ah true, I missed the "while" here.
  6. Christian Eßl commented on patch set 2 10/07/19, 15:14

    FormPersistenceManager.php:368 Reply

    Ack
  7. Sascha Rademacher voted on patch set 2 CR +1 10/09/19, 09:15

  8. Susi Moog voted on patch set 2 CR +1 10/09/19, 11:10

  9. Christian Eßl updated the commit message in patch set 3 10/15/19, 11:41

  10. TYPO3com voted on patch set 3 V +1 10/15/19, 11:51 Completed build in 10m 13s on Tue, 15 Oct, 11:51 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37333

  11. Susi Moog voted on patch set 3 CR +1 11/09/19, 12:20

  12. Susi Moog voted on patch set 3 V +1 11/09/19, 12:22

  13. Guido Schmechel commented on patch set 3 11/09/19, 14:01

    FormPersistenceManager.php:368 Unresolved

    What happens if we have more than two occurrences? Is that technically possible?
  14. Daniel Goerz commented on patch set 3 11/09/19, 14:30

    With the patch applied I can see form definitions with the same filename from different storages. But all of those have duplicated identifier warnings now.
  15. Susi Moog commented on patch set 3 CR -1 11/09/19, 16:48

    let's look at this at the form sprint
  16. Ralf Zimmermann uploaded patch set 4 11/22/19, 14:29

  17. TYPO3com voted on patch set 4 V +1 11/22/19, 14:36 Completed build in 06m 51s on Fri, 22 Nov, 02:36 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38643

  18. Ralf Zimmermann voted on patch set 4 V +1 CR +1 11/22/19, 16:36

  19. Susi Moog voted on patch set 4 V +1 CR +1 11/22/19, 19:10

  20. Björn Jacob updated the commit message in patch set 5 11/22/19, 19:11

  21. Susi Moog voted on patch set 5 V +1 CR +1 11/22/19, 19:11

  22. Björn Jacob voted on patch set 5 V +1 CR +1 11/22/19, 19:15

  23. TYPO3com voted on patch set 5 V +1 11/22/19, 19:19 Completed build in 08m 23s on Fri, 22 Nov, 07:19 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38694

  24. Ralf Zimmermann voted on patch set 5 V +2 CR +2 11/22/19, 19:19

  25. Ralf Zimmermann merged patch set 6 11/22/19, 19:19