61891[BUGFIX] Show form definitions with same filename from different storages
Commit message
Review
-
Code review CR +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
- Susi Moog +1
-
Verified V +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2227
Show 12 earlier messages
-
Christian Eßl uploaded patch set 1 10/05/19, 09:02
-
TYPO3com voted on patch set 1 V -1 10/05/19, 09:02 Completed build in 11s on Sat, 5 Oct, 09:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37056
-
Christian Eßl uploaded patch set 2 10/05/19, 09:13
-
TYPO3com voted on patch set 2 V +1 10/05/19, 09:23 Completed build in 09m 58s on Sat, 5 Oct, 09:23 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37057
-
Mathias Brodala commented on patch set 2 10/07/19, 06:54
-
Christian Eßl commented on patch set 2 10/07/19, 07:03
FormPersistenceManager.php:368ReplyI made it behave exactly the same as in getFilesInFolder(): (which is called from FormPersistenceManager) https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Resource/ResourceStorage.php#L1547 It will append 'z' until the $key is unique. -
Mathias Brodala commented on patch set 2 10/07/19, 07:05
FormPersistenceManager.php:368ReplyAh true, I missed the "while" here. -
Christian Eßl commented on patch set 2 10/07/19, 15:14
FormPersistenceManager.php:368ReplyAck -
Sascha Rademacher voted on patch set 2 CR +1 10/09/19, 09:15
-
Susi Moog voted on patch set 2 CR +1 10/09/19, 11:10
-
Christian Eßl updated the commit message in patch set 3 10/15/19, 11:41
-
TYPO3com voted on patch set 3 V +1 10/15/19, 11:51 Completed build in 10m 13s on Tue, 15 Oct, 11:51 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37333
-
Susi Moog voted on patch set 3 CR +1 11/09/19, 12:20
-
Susi Moog voted on patch set 3 V +1 11/09/19, 12:22
-
Guido Schmechel commented on patch set 3 11/09/19, 14:01
FormPersistenceManager.php:368UnresolvedWhat happens if we have more than two occurrences? Is that technically possible? -
Daniel Goerz commented on patch set 3 11/09/19, 14:30
With the patch applied I can see form definitions with the same filename from different storages. But all of those have duplicated identifier warnings now. -
Susi Moog commented on patch set 3 CR -1 11/09/19, 16:48
let's look at this at the form sprint -
Ralf Zimmermann uploaded patch set 4 11/22/19, 14:29
-
TYPO3com voted on patch set 4 V +1 11/22/19, 14:36 Completed build in 06m 51s on Fri, 22 Nov, 02:36 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38643
-
Ralf Zimmermann voted on patch set 4 V +1 CR +1 11/22/19, 16:36
-
Susi Moog voted on patch set 4 V +1 CR +1 11/22/19, 19:10
-
Björn Jacob updated the commit message in patch set 5 11/22/19, 19:11
-
Susi Moog voted on patch set 5 V +1 CR +1 11/22/19, 19:11
-
Björn Jacob voted on patch set 5 V +1 CR +1 11/22/19, 19:15
-
TYPO3com voted on patch set 5 V +1 11/22/19, 19:19 Completed build in 08m 23s on Fri, 22 Nov, 07:19 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38694
-
Ralf Zimmermann voted on patch set 5 V +2 CR +2 11/22/19, 19:19
-
Ralf Zimmermann merged patch set 6 11/22/19, 19:19
FormPersistenceManager.php:368