Review main Merged

61892[BUGFIX] Prevent broken AND where statement in cObj->searchWhere()

Christian Eßl CR +2 V +2 Easy +24 −5 updated 10/10/19, 14:46

Commit message

If searchWhere() in ContentObjectRenderer is called with search words
that are smaller than 3 characters in length, a broken " AND " where
statement will be returned, that, if put inside a database query, would
lead to a fatal error. In such a case, return an empty string to prevent addWhere call.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Julian Geils +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1722

  1. Christian Eßl uploaded patch set 1 10/05/19, 10:58

  2. TYPO3com voted on patch set 1 V +1 10/05/19, 11:09 Completed build in 10m 22s on Sat, 5 Oct, 11:09 AM Test Summary: 47762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37058

  3. Christoph Lehmann commented on patch set 1 10/06/19, 17:09

    Would we refactor the function in master to return nothing if $where is empty?
  4. Daniel Goerz commented on patch set 1 10/06/19, 19:33

    ContentObjectRenderer.php:6140

    Is there any reason for returning this "ugly" 1=1 construct? I'd rather see an empty string returned, which should do the same thing, if I am not missing anything.
  5. Mathias Brodala commented on patch set 1 10/07/19, 06:51

    ContentObjectRenderer.php:6140 Reply Unresolved

    I agree. This should be normalized in the guard clause above too, then.
  6. Jörg Bösche uploaded patch set 2 10/07/19, 08:16

  7. Markus Klein voted on patch set 2 V +1 CR +1 10/07/19, 08:20

  8. TYPO3com voted on patch set 2 V -1 10/07/19, 08:26 Completed build in 09m 52s on Mon, 7 Oct, 08:26 AM Test Summary: 47508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37079

  9. Daniel Goerz commented on patch set 2 CR -1 10/07/19, 09:00

    Unresolved

    This is no longer true

    Unresolved

    Would probably not backport to 8.7, not a priority bugfix.
  10. TYPO3com voted on patch set 2 V +1 10/07/19, 09:08 Completed build in 10m 24s on Mon, 7 Oct, 09:08 AM Test Summary: 47762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37082

  11. Jörg Bösche updated the commit message in patch set 3 10/07/19, 09:55

  12. Julian Geils voted on patch set 3 V +1 CR +1 10/08/19, 11:45

  13. Julian Geils commented on patch set 3 10/08/19, 11:58

    verified for master and 9.5
  14. TYPO3com voted on patch set 3 V +1 10/08/19, 14:45 Completed build in 09m 33s on Tue, 8 Oct, 02:45 PM Test Summary: 47722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37147

  15. Sascha Rademacher voted on patch set 3 CR +1 10/09/19, 07:15

  16. Daniel Goerz uploaded patch set 4 10/09/19, 13:27

  17. TYPO3com voted on patch set 4 V +1 10/09/19, 13:41 Completed build in 13m 05s on Wed, 9 Oct, 01:41 PM Test Summary: 47722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37187

  18. Jörg Bösche voted on patch set 4 CR +1 10/09/19, 13:42

  19. Sascha Rademacher voted on patch set 4 CR +1 10/10/19, 07:00

  20. Julian Geils voted on patch set 4 V +1 CR +1 10/10/19, 13:11

  21. Daniel Goerz voted on patch set 4 V +2 CR +2 10/10/19, 14:46

  22. Daniel Goerz merged patch set 5 10/10/19, 14:46