Review main Merged

61894[TASK] Warn in [SYS][UTF8filesystem] that a valid UTF-8 locale is necessary

Christian Eßl CR +2 V +2 Easy +6 −1 updated 10/11/19, 19:47

Commit message

Add a small warning in the "Configure Installation-Wide Options" modal
for [SYS][UTF8filesystem], that warns users about the fact, that a valid
UTF-8 compatible locale string is necessary as well, in order to not
produce weird bugs when handling files with special characters.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Sascha Rademacher +1
    • Julian Geils +1
    • Henning Liebe +1
    • Jörg Bösche +1
    • Mathias Brodala +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Christian Eßl uploaded patch set 1 10/05/19, 15:56

  2. TYPO3com voted on patch set 1 V +1 10/05/19, 16:07 Completed build in 10m 30s on Sat, 5 Oct, 04:07 PM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37061

  3. Mathias Brodala commented on patch set 1 10/07/19, 06:47

    DefaultConfigurationDescription.yaml:150 Unresolved

    This should only be "locale" instead.
  4. Jörg Bösche uploaded patch set 2 10/07/19, 08:27

  5. TYPO3com voted on patch set 2 V +1 10/07/19, 08:37 Completed build in 10m 15s on Mon, 7 Oct, 08:37 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37080

  6. Mathias Brodala voted on patch set 2 CR +1 10/07/19, 08:52

  7. Henning Liebe voted on patch set 2 CR +1 10/07/19, 09:21

  8. Jörg Bösche voted on patch set 2 CR +1 10/07/19, 12:36

  9. Sascha Rademacher voted on patch set 2 CR +1 10/08/19, 07:14

  10. Daniel Goerz voted on patch set 2 V +1 CR +1 10/08/19, 07:35

  11. Steffen Frese voted on patch set 2 CR +1 10/08/19, 07:58

  12. Julian Geils voted on patch set 2 CR +1 10/08/19, 08:06

  13. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/11/19, 19:47

  14. Anja Leichsenring merged patch set 3 10/11/19, 19:47