Review main Merged

61896[FEATURE] Provide a way to sort form lists in ext:form

Christian Eßl CR +2 V +2 Normal +182 −1 updated 11/09/19, 13:58

Commit message

Forms in ext:form were previously not sorted in any manner, but just
outputted in the order they were read from the filesystem's directories.

Forms can now be sorted by multiple keys in either ascending or
descending order.
Two new yaml settings were introduced: `sortByKeys` and `sortAscending`.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1317

  1. Christian Eßl uploaded patch set 1 10/06/19, 09:06

  2. TYPO3com voted on patch set 1 V +1 10/06/19, 09:16 Completed build in 10m 09s on Sun, 6 Oct, 09:16 AM Test Summary: 47758 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37063

  3. Daniel Siepmann uploaded patch set 2 10/07/19, 10:19

  4. Daniel Siepmann uploaded patch set 3 10/07/19, 10:29

  5. TYPO3com voted on patch set 2 V -1 10/07/19, 10:52 Completed build in 18m 33s on Mon, 7 Oct, 10:52 AM Test Summary: 47682 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37092

  6. TYPO3com voted on patch set 3 V +1 10/07/19, 11:09 Completed build in 35m 12s on Mon, 7 Oct, 11:09 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37093

  7. Sascha Rademacher voted on patch set 3 CR +1 10/07/19, 11:29

  8. Sascha Rademacher voted on patch set 3 V +1 10/07/19, 11:30

  9. Daniel Goerz commented on patch set 3 10/08/19, 07:27

    FormPersistenceManager.php:782

    Do we want to enforce our default here again, in case somebody does manage to have those array keys not set?
  10. Susi Moog commented on patch set 3 11/09/19, 11:15

    FormPersistenceManager.php:782 Reply Unresolved

    yes please, for both.
  11. Daniel Goerz uploaded patch set 4 11/09/19, 12:23

  12. Susi Moog voted on patch set 4 CR +1 11/09/19, 12:35

  13. TYPO3com voted on patch set 4 V +1 11/09/19, 12:36 Completed build in 09m 52s on Sat, 9 Nov, 12:36 PM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38164

  14. Susi Moog voted on patch set 4 V +1 11/09/19, 13:10

  15. Daniel Goerz voted on patch set 4 CR +1 11/09/19, 13:17

  16. Daniel Goerz voted on patch set 4 V +2 CR +2 11/09/19, 13:58

  17. Daniel Goerz merged patch set 5 11/09/19, 13:58