Review main Merged

61898[TASK] Show peak memory usage in MB

Christoph Lehmann CR +2 V +2 Easy +1 −1 updated 10/08/19, 04:08

Commit message

For better readability, the peak memory usage is now converted to
megabytes.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Julian Geils +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Julian Geils +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2028

Show 23 earlier messages
  1. Christoph Lehmann uploaded patch set 1 10/06/19, 21:21

  2. TYPO3com voted on patch set 1 V -1 10/06/19, 21:30 Completed build in 09m 14s on Sun, 6 Oct, 09:30 PM Test Summary: 47508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37072

  3. Andreas Kienast updated the commit message in patch set 2 10/07/19, 06:22

  1. TYPO3com voted on patch set 2 V +1 10/07/19, 06:42 Completed build in 12m 40s on Mon, 7 Oct, 06:42 AM Test Summary: 47759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37073

  2. Jörg Bösche voted on patch set 2 V +1 CR +1 10/07/19, 08:30

  3. Henning Liebe voted on patch set 2 CR +1 10/07/19, 09:22

  4. Steffen Frese voted on patch set 2 V +1 CR +1 10/07/19, 11:27

  5. Jan Stockfisch voted on patch set 2 CR +1 10/07/19, 11:30

  6. Sascha Rademacher voted on patch set 2 CR +1 10/07/19, 11:35

  7. Sascha Rademacher voted on patch set 2 V +1 10/07/19, 11:37

  8. Frank Nägler commented on patch set 2 CR -1 10/07/19, 11:48

    PhpInformation.php:63

    please use GeneralUtitlity::formatSize for the formating,
  9. Andreas Kienast uploaded patch set 3 10/07/19, 12:13

  10. Sascha Rademacher voted on patch set 3 V +1 CR +1 10/07/19, 12:24

  11. TYPO3com voted on patch set 3 V +1 10/07/19, 12:25 Completed build in 12m 06s on Mon, 7 Oct, 12:25 PM Test Summary: 47717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37102

  12. Jörg Bösche rebased onto patch set 4 10/07/19, 12:30

  13. Jörg Bösche commented on patch set 4 10/07/19, 12:31

    The GeneralUtility::formatSize() is implemented. Will output "4.72 Mi", instead of "4.72 MB".

    PhpInformation.php:63 Reply

    Done
  14. Steffen Frese voted on patch set 4 V +1 CR +1 10/07/19, 12:39

  15. Henning Liebe uploaded patch set 5 10/07/19, 12:40

  16. Jörg Bösche uploaded patch set 6 10/07/19, 12:45

  17. TYPO3com voted on patch set 4 V -1 10/07/19, 12:51 Completed build in 19m 25s on Mon, 7 Oct, 12:51 PM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37105

  18. TYPO3com voted on patch set 5 V +1 10/07/19, 13:00 Completed build in 15m 55s on Mon, 7 Oct, 01:00 PM Test Summary: 47717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37106

  19. TYPO3com voted on patch set 6 V -1 10/07/19, 13:02 Completed build in 13m 11s on Mon, 7 Oct, 01:02 PM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37108

  20. TYPO3com commented on patch set 6 10/07/19, 13:17 Completed build in 23m 25s on Mon, 7 Oct, 01:17 PM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37110

  21. TYPO3com voted on patch set 6 V +1 10/07/19, 14:00 Completed build in 1h 30m 03s on Mon, 7 Oct, 02:00 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37110

  22. Frank Nägler voted on patch set 6 V +1 CR +1 10/07/19, 14:12

  23. Julian Geils voted on patch set 6 V +1 CR +1 10/07/19, 14:42

  24. Georg Ringer voted on patch set 6 V +2 CR +2 10/08/19, 04:08

  25. Georg Ringer merged patch set 7 10/08/19, 04:08