61902[TASK] Give better info about no records
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Jörg Bösche +1
-
Verified V +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1319
-
Pascal Querner uploaded patch set 1 10/07/19, 12:44
-
TYPO3com voted on patch set 1 V -1 10/07/19, 12:45 Completed build in 27s on Mon, 7 Oct, 12:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37107
-
TYPO3com commented on patch set 1 10/07/19, 13:22 Completed build in 28s on Mon, 7 Oct, 01:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37112
-
Andreas Kienast commented on patch set 1 CR -1 10/07/19, 13:30
RecordListController.php:467Unresolvedfalse -
Pascal Querner rebased onto patch set 2 10/07/19, 13:41
-
TYPO3com voted on patch set 2 V -1 10/07/19, 13:41 Completed build in 15s on Mon, 7 Oct, 01:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37113
-
Andreas Kienast uploaded patch set 3 10/07/19, 13:51
-
Andreas Kienast uploaded patch set 4 10/07/19, 13:52
-
Andreas Kienast uploaded patch set 5 10/07/19, 13:54
-
TYPO3com voted on patch set 3 V -1 10/07/19, 13:57 Completed build in 06m 12s on Mon, 7 Oct, 01:57 PM Test Summary: 30 of 44008 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37115
-
TYPO3com voted on patch set 4 V -1 10/07/19, 13:57 Completed build in 05m 25s on Mon, 7 Oct, 01:57 PM Test Summary: 1 of 10051 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37116
-
TYPO3com voted on patch set 5 V +1 10/07/19, 14:05 Completed build in 08m 12s on Mon, 7 Oct, 02:05 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37117
-
Jörg Bösche commented on patch set 5 CR -1 10/08/19, 06:19
RecordListController.php:471Shouldnt we define this else case as default $ll variable before the isset TCA field check? -
Pascal Querner commented on patch set 5 10/08/19, 07:43
RecordListController.php:471Reply UnresolvedI had it as default previously, but Andreas changed the code structure to be more optimised. Also $this->table is NULL when no table records is asked, therefore it should switch directly into the else case and not also check the TCA. -
Sascha Rademacher voted on patch set 5 CR +1 10/10/19, 08:34
-
Sascha Rademacher voted on patch set 5 V +1 10/10/19, 08:58
-
Jörg Bösche voted on patch set 5 V +1 CR +1 10/10/19, 09:00
-
Susi Moog voted on patch set 5 V +2 CR +2 10/10/19, 09:37
-
Susi Moog merged patch set 6 10/10/19, 09:37
locallang_mod_web_list.xlf:162Unresolved