Review main Merged

61902[TASK] Give better info about no records

Pascal Querner CR +2 V +2 Easy +14 −1 updated 10/10/19, 09:37

Commit message

This patch adds a better info text when no records of a specific type
don't exist, instead of giving the generic answer "no records exists on
this page" (which may not be true).

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1319

  1. Pascal Querner uploaded patch set 1 10/07/19, 12:44

  2. TYPO3com voted on patch set 1 V -1 10/07/19, 12:45 Completed build in 27s on Mon, 7 Oct, 12:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37107

  3. TYPO3com commented on patch set 1 10/07/19, 13:22 Completed build in 28s on Mon, 7 Oct, 01:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37112

  4. Andreas Kienast commented on patch set 1 CR -1 10/07/19, 13:30

    locallang_mod_web_list.xlf:162 Unresolved

    Please keep the `resname` attribute

    RecordListController.php:467 Unresolved

    false
  5. Pascal Querner rebased onto patch set 2 10/07/19, 13:41

  6. TYPO3com voted on patch set 2 V -1 10/07/19, 13:41 Completed build in 15s on Mon, 7 Oct, 01:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37113

  7. Andreas Kienast uploaded patch set 3 10/07/19, 13:51

  8. Andreas Kienast uploaded patch set 4 10/07/19, 13:52

  9. Andreas Kienast uploaded patch set 5 10/07/19, 13:54

  10. TYPO3com voted on patch set 3 V -1 10/07/19, 13:57 Completed build in 06m 12s on Mon, 7 Oct, 01:57 PM Test Summary: 30 of 44008 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37115

  11. TYPO3com voted on patch set 4 V -1 10/07/19, 13:57 Completed build in 05m 25s on Mon, 7 Oct, 01:57 PM Test Summary: 1 of 10051 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37116

  12. TYPO3com voted on patch set 5 V +1 10/07/19, 14:05 Completed build in 08m 12s on Mon, 7 Oct, 02:05 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37117

  13. Jörg Bösche commented on patch set 5 CR -1 10/08/19, 06:19

    RecordListController.php:471

    Shouldnt we define this else case as default $ll variable before the isset TCA field check?
  14. Pascal Querner commented on patch set 5 10/08/19, 07:43

    RecordListController.php:471 Reply Unresolved

    I had it as default previously, but Andreas changed the code structure to be more optimised. Also $this->table is NULL when no table records is asked, therefore it should switch directly into the else case and not also check the TCA.
  15. Sascha Rademacher voted on patch set 5 CR +1 10/10/19, 08:34

  16. Sascha Rademacher voted on patch set 5 V +1 10/10/19, 08:58

  17. Jörg Bösche voted on patch set 5 V +1 CR +1 10/10/19, 09:00

  18. Susi Moog voted on patch set 5 V +2 CR +2 10/10/19, 09:37

  19. Susi Moog merged patch set 6 10/10/19, 09:37