61905[BUGFIX] Prevent 500 Internal server error in flexform
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Sascha Rademacher +1
- Jörg Bösche +1
- Felix P. +1
- Andreas Kienast +1
- Henning Liebe +1
-
Verified V +2 Done
- Georg Ringer +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 810
-
Frank Nägler uploaded patch set 1 10/08/19, 07:32
-
TYPO3com voted on patch set 1 V -1 10/08/19, 07:44 Completed build in 12m 12s on Tue, 8 Oct, 07:44 AM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37126
-
TYPO3com voted on patch set 1 V +1 10/08/19, 09:03 Completed build in 10m 11s on Tue, 8 Oct, 09:03 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37133
-
Sascha Rademacher voted on patch set 1 CR +1 10/08/19, 09:17
-
Jörg Bösche commented on patch set 1 V +1 CR +1 10/08/19, 09:33
Tested with v9.5.9 and master. Added the example from forge to flexform and could not reproduce the behavior. After set the variable $treeData to null in typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php:183 it was possible to reproduce. IMO it is right to check the variable to prevent the exeception and later the 500 internal server error in flexform. -
Felix P. voted on patch set 1 CR +1 10/08/19, 11:18
-
Andreas Kienast voted on patch set 1 CR +1 10/08/19, 11:33
-
Henning Liebe voted on patch set 1 CR +1 10/08/19, 11:34
-
Georg Ringer voted on patch set 1 V +2 CR +2 10/08/19, 11:54
-
Georg Ringer merged patch set 2 10/08/19, 11:54