61906[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- Markus Klein +1
- Susi Moog +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 3
Files 2
Review log 2230
Show 45 earlier messages
-
Daniel Goerz uploaded patch set 1 10/08/19, 08:30
-
Daniel Goerz voted on patch set 1 CR -1 10/08/19, 08:31
-
Mathias Brodala commented on patch set 1 CR -1 10/08/19, 08:34
BackendUserConfigurationUpdate.php:67This is potentially unsafe, you must explicitly allow unserialization of stdClass here: unserialize($backendUser['uc'], ['allowed_classes' => ['stdClass']]);BackendUserConfigurationUpdate.php:101For this basic query you could use Connection::select() instead.BackendUserConfigurationUpdate.php:104See above.BackendUserConfigurationUpdate.php:106If not used you can simply drop this argument.BackendUserConfigurationUpdate.php:121For this basic query you could use Connection::update() instead. -
Daniel Goerz commented on patch set 1 10/08/19, 08:35
Patch was previously available here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61874 -
TYPO3com voted on patch set 1 V +1 10/08/19, 08:40 Completed build in 10m 00s on Tue, 8 Oct, 08:40 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37132
-
Jörg Bösche uploaded patch set 2 10/09/19, 11:39
-
Jörg Bösche commented on patch set 2 10/09/19, 11:42
BackendUserConfigurationUpdate.php:63ReplyDoneBackendUserConfigurationUpdate.php:67ReplyDoneBackendUserConfigurationUpdate.php:101ReplyCould not use Connection::select() because of LIKE statement. The connection select() method iterates over the statements and pushs the data to an equals() method. I did an extraction to a method to reuse the query in the "update necessary" and "executeUpdate" methods.BackendUserConfigurationUpdate.php:104ReplyDoneBackendUserConfigurationUpdate.php:106ReplyDoneBackendUserConfigurationUpdate.php:121ReplyDone -
Jörg Bösche uploaded patch set 3 10/09/19, 11:44
-
TYPO3com voted on patch set 2 V -1 10/09/19, 11:51 Completed build in 11m 28s on Wed, 9 Oct, 11:51 AM Test Summary: 47216 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37174
-
TYPO3com voted on patch set 3 V -1 10/09/19, 11:57 Completed build in 12m 34s on Wed, 9 Oct, 11:57 AM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37175
-
TYPO3com voted on patch set 3 V +1 10/09/19, 12:16 Completed build in 18m 56s on Wed, 9 Oct, 12:16 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37178
-
Mathias Brodala commented on patch set 3 CR -1 10/09/19, 12:38
BackendUserConfigurationUpdate.php:64UnresolvedYou can simply use foreach ($statement as $backendUser)BackendUserConfigurationUpdate.php:116UnresolvedYou should use `Doctrine\DBAL\Driver\Statement` instead here, otherwise this will crash on any other DBMS. -
Jörg Bösche uploaded patch set 4 10/09/19, 13:18
-
Mathias Brodala commented on patch set 5 10/09/19, 13:25
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V -1 10/09/19, 13:26 Completed build in 15s on Wed, 9 Oct, 01:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37185
-
TYPO3com voted on patch set 4 V +1 10/09/19, 13:26 Completed build in 08m 00s on Wed, 9 Oct, 01:26 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37184
-
Mathias Brodala commented on patch set 6 10/09/19, 13:27
Published edit on patch set 5. -
Mathias Brodala voted on patch set 6 CR +1 10/09/19, 13:28
-
TYPO3com voted on patch set 6 V +1 10/09/19, 13:38 Completed build in 11m 20s on Wed, 9 Oct, 01:38 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37186
-
Markus Klein commented on patch set 6 10/14/19, 11:24
BackendUserConfigurationUpdate.php:128UnresolvedThis is not needed, since we specify the string ourselves -
Christian Eßl uploaded patch set 7 10/14/19, 15:31
-
TYPO3com voted on patch set 7 V +1 10/14/19, 15:46 Completed build in 12m 43s on Mon, 14 Oct, 03:46 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37318
-
Markus Klein voted on patch set 7 CR +1 10/14/19, 18:56
-
Tymoteusz Motylewski commented on patch set 7 10/19/19, 19:51
How this can be tested? -
Daniel Goerz voted on patch set 7 V +1 CR +1 10/21/19, 15:22
-
Susi Moog voted on patch set 7 CR +1 10/28/19, 20:17
-
Markus Klein commented on patch set 7 V +1 10/29/19, 15:16
tested with an upgrade from v7 to v9 -
Tymoteusz Motylewski voted on patch set 7 V +2 CR +2 10/29/19, 15:17
-
Tymoteusz Motylewski merged patch set 8 10/29/19, 15:17
-
Daniel Goerz commented on patch set 8 11/22/19, 09:37
Pending BUGFIX for this UpgradeWizard: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62368
BackendUserConfigurationUpdate.php:63