Review main Merged

61908[BUGFIX] Add tests and fix broken MailMessage

Frank Nägler CR +2 V +2 Hard +413 −75 updated 01/12/20, 12:19

Commit message

This patch add tests for the MailMessage class and fix broken
functionality since migration to Symfony Mailer.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1217

  1. Frank Nägler uploaded patch set 1 10/08/19, 11:50

  2. Susi Moog uploaded patch set 2 10/08/19, 13:48

  3. Frank Nägler uploaded patch set 3 10/08/19, 14:49

  4. Frank Nägler wrote 10/08/19, 14:49

    Unset private
  5. Frank Nägler uploaded patch set 4 10/08/19, 14:54

  6. TYPO3com voted on patch set 3 V -1 10/08/19, 14:58 Completed build in 09m 22s on Tue, 8 Oct, 02:58 PM Test Summary: 47939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37148

  7. TYPO3com voted on patch set 4 V -1 10/08/19, 15:05 Completed build in 10m 56s on Tue, 8 Oct, 03:05 PM Test Summary: 1 of 48306 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37149

  8. Andreas Kienast uploaded patch set 5 10/08/19, 15:06

  9. Andreas Kienast voted on patch set 5 V +1 CR +1 10/08/19, 15:16

  10. TYPO3com voted on patch set 5 V -1 10/08/19, 15:17 Completed build in 10m 47s on Tue, 8 Oct, 03:17 PM Test Summary: 1 of 48306 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37151

  11. TYPO3com commented on patch set 5 10/08/19, 17:57 Completed build in 3h 01m 59s on Tue, 8 Oct, 05:57 PM Test Summary: 47947 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37151

  12. Andreas Kienast uploaded patch set 6 10/09/19, 06:22

  13. TYPO3com voted on patch set 6 V +1 10/09/19, 06:36 Completed build in 14m 15s on Wed, 9 Oct, 06:36 AM Test Summary: 47947 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37159

  14. Andreas Kienast voted on patch set 6 V +1 CR +1 10/09/19, 06:55

  15. Daniel Goerz voted on patch set 6 V +2 CR +2 10/10/19, 14:50

  16. Daniel Goerz merged patch set 7 10/10/19, 14:50

  17. Markus Klein commented on patch set 7 01/12/20, 12:19

    Why do we introduce an InvalidArgumentException in Core?? I don't think it's clever to name that exactly like the PHP's native exception https://www.php.net/manual/de/class.invalidargumentexception.php (which is a LogicException and not a RuntimeException)