61910[BUGFIX] Fix preprocessing of external URLs in linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Sascha Rademacher +1
- Julian Geils +1
- Jörg Bösche +1
- Felix P. +1
-
Verified V +2 Done
- Daniel Goerz +2
- Sascha Rademacher +1
- Julian Geils +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1825
-
Sybille Peters uploaded patch set 1 10/08/19, 16:52
-
TYPO3com voted on patch set 1 V -1 10/08/19, 17:02 Completed build in 09m 42s on Tue, 8 Oct, 05:02 PM Test Summary: 47498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37155
-
Sybille Peters uploaded patch set 2 10/08/19, 17:09
-
TYPO3com voted on patch set 2 V +1 10/08/19, 17:19 Completed build in 10m 18s on Tue, 8 Oct, 05:19 PM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37156
-
Georg Ringer commented on patch set 2 10/08/19, 18:29
-
Sybille Peters uploaded patch set 3 10/09/19, 07:23
-
Sybille Peters commented on patch set 3 10/09/19, 07:24
ExternalLinktype.php:215ReplyDoes not, really. I changed it. -
TYPO3com voted on patch set 3 V -1 10/09/19, 07:32 Completed build in 08m 52s on Wed, 9 Oct, 07:32 AM Test Summary: 1 of 47828 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37161
-
TYPO3com voted on patch set 3 V +1 10/09/19, 07:43 Completed build in 28m 31s on Wed, 9 Oct, 07:43 AM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37161
-
Jörg Bösche commented on patch set 3 CR -1 10/09/19, 08:31
ExternalLinktypeTest.php:129Instead of an array as a return value, I would prefer to use a generator. DataProviders support generators. yield 'URL with path with dashes' => [...]; yield 'domain with special characters' => [...]; ... -
Henning Liebe commented on patch set 3 10/09/19, 12:07
ExternalLinktypeTest.php:133IMO you should not use real existing domains like nbank.de -
Sybille Peters uploaded patch set 4 10/09/19, 12:21
-
Sybille Peters uploaded patch set 5 10/09/19, 12:25
-
Sybille Peters commented on patch set 5 10/09/19, 12:25
ExternalLinktypeTest.php:129ReplyDoneExternalLinktypeTest.php:133ReplyDone -
Sybille Peters updated the commit message in patch set 6 10/09/19, 12:27
-
TYPO3com voted on patch set 4 V -1 10/09/19, 12:33 Completed build in 11m 58s on Wed, 9 Oct, 12:33 PM Test Summary: 47741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37179
-
TYPO3com voted on patch set 5 V +1 10/09/19, 12:36 Completed build in 10m 59s on Wed, 9 Oct, 12:36 PM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37180
-
TYPO3com voted on patch set 6 V +1 10/09/19, 12:40 Completed build in 11m 59s on Wed, 9 Oct, 12:40 PM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37181
-
Jörg Bösche voted on patch set 6 V +1 CR +1 10/10/19, 06:58
-
Sascha Rademacher voted on patch set 6 V +1 CR +1 10/10/19, 07:39
-
Felix P. voted on patch set 6 CR +1 10/10/19, 08:08
-
Julian Geils voted on patch set 6 V +1 CR +1 10/10/19, 13:04
-
Daniel Goerz voted on patch set 6 V +2 CR +2 10/10/19, 13:47
-
Daniel Goerz merged patch set 7 10/10/19, 13:47
-
Daniel Goerz commented on patch set 7 10/10/19, 13:54
I just realized when starting to manually backport that looks like an master-only issue as in 9.5 the preprocessUrl() method works differently (and I was not able to reproduce the bug). Sybille, can you confirm?
ExternalLinktype.php:215