Review main Merged

61910[BUGFIX] Fix preprocessing of external URLs in linkvalidator

Sybille Peters CR +2 V +2 Normal +62 −2 updated 10/10/19, 13:54

Commit message

Fix the preprocessing of external URLs that was originally
introduced to handle domains with special characters (conversion
to punycode). The previous functionality had the unintended side
effect of truncating some URLs to empty strings and leading to
falsely reported broken links.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Jörg Bösche +1
    • Felix P. +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1825

  1. Sybille Peters uploaded patch set 1 10/08/19, 16:52

  2. TYPO3com voted on patch set 1 V -1 10/08/19, 17:02 Completed build in 09m 42s on Tue, 8 Oct, 05:02 PM Test Summary: 47498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37155

  3. Sybille Peters uploaded patch set 2 10/08/19, 17:09

  4. TYPO3com voted on patch set 2 V +1 10/08/19, 17:19 Completed build in 10m 18s on Tue, 8 Oct, 05:19 PM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37156

  5. Georg Ringer commented on patch set 2 10/08/19, 18:29

    ExternalLinktype.php:215

    why does this need to be public now?
  6. Sybille Peters uploaded patch set 3 10/09/19, 07:23

  7. Sybille Peters commented on patch set 3 10/09/19, 07:24

    ExternalLinktype.php:215 Reply

    Does not, really. I changed it.
  8. TYPO3com voted on patch set 3 V -1 10/09/19, 07:32 Completed build in 08m 52s on Wed, 9 Oct, 07:32 AM Test Summary: 1 of 47828 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37161

  9. TYPO3com voted on patch set 3 V +1 10/09/19, 07:43 Completed build in 28m 31s on Wed, 9 Oct, 07:43 AM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37161

  10. Jörg Bösche commented on patch set 3 CR -1 10/09/19, 08:31

    ExternalLinktypeTest.php:129

    Instead of an array as a return value, I would prefer to use a generator. DataProviders support generators. yield 'URL with path with dashes' => [...]; yield 'domain with special characters' => [...]; ...
  11. Henning Liebe commented on patch set 3 10/09/19, 12:07

    ExternalLinktypeTest.php:133

    IMO you should not use real existing domains like nbank.de
  12. Sybille Peters uploaded patch set 4 10/09/19, 12:21

  13. Sybille Peters uploaded patch set 5 10/09/19, 12:25

  14. Sybille Peters commented on patch set 5 10/09/19, 12:25

    ExternalLinktypeTest.php:129 Reply

    Done

    ExternalLinktypeTest.php:133 Reply

    Done
  15. Sybille Peters updated the commit message in patch set 6 10/09/19, 12:27

  16. TYPO3com voted on patch set 4 V -1 10/09/19, 12:33 Completed build in 11m 58s on Wed, 9 Oct, 12:33 PM Test Summary: 47741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37179

  17. TYPO3com voted on patch set 5 V +1 10/09/19, 12:36 Completed build in 10m 59s on Wed, 9 Oct, 12:36 PM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37180

  18. TYPO3com voted on patch set 6 V +1 10/09/19, 12:40 Completed build in 11m 59s on Wed, 9 Oct, 12:40 PM Test Summary: 47751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37181

  19. Jörg Bösche voted on patch set 6 V +1 CR +1 10/10/19, 06:58

  20. Sascha Rademacher voted on patch set 6 V +1 CR +1 10/10/19, 07:39

  21. Felix P. voted on patch set 6 CR +1 10/10/19, 08:08

  22. Julian Geils voted on patch set 6 V +1 CR +1 10/10/19, 13:04

  23. Daniel Goerz voted on patch set 6 V +2 CR +2 10/10/19, 13:47

  24. Daniel Goerz merged patch set 7 10/10/19, 13:47

  25. Daniel Goerz commented on patch set 7 10/10/19, 13:54

    I just realized when starting to manually backport that looks like an master-only issue as in 9.5 the preprocessUrl() method works differently (and I was not able to reproduce the bug). Sybille, can you confirm?