Review main Merged

61911[BUGFIX] Generate unique id for checkboxes in flexform sections

Georg Ringer CR +2 V +2 Easy +1 −1 updated 10/09/19, 07:56

Commit message

Use a checksum of the element's name as additional identifier to generate
an unique id for checkboxes in flexform sections.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Armin Vieweg +1
    • Jörg Bösche +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Georg Ringer uploaded patch set 1 10/09/19, 01:33

  2. TYPO3com voted on patch set 1 V -1 10/09/19, 01:33 Completed build in 12s on Wed, 9 Oct, 01:33 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37157

  3. Georg Ringer uploaded patch set 2 10/09/19, 01:36

  4. Georg Ringer commented on patch set 2 10/09/19, 01:36

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 10/09/19, 01:45 Completed build in 09m 43s on Wed, 9 Oct, 01:45 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37158

  6. Christian Eßl commented on patch set 2 CR +1 10/09/19, 05:47

    Works for me.
  7. Julian Geils voted on patch set 2 CR +1 10/09/19, 06:12

  8. Sascha Rademacher voted on patch set 2 V +1 CR +1 10/09/19, 06:22

  9. Christian Eßl voted on patch set 2 V +1 10/09/19, 06:28

  10. Jörg Bösche commented on patch set 2 V +1 CR +1 10/09/19, 06:47

    Verified on master and v9.5.9
  11. Armin Vieweg voted on patch set 2 CR +1 10/09/19, 07:03

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 10/09/19, 07:56

  13. Andreas Kienast merged patch set 3 10/09/19, 07:56