Review 9.5 Merged

61915[BUGFIX] Reset belog search constraints on memory exhaustion

Tobi Kretschmann CR +2 V +2 Easy +19 −0 updated 10/09/19, 06:22

Commit message

If a backend user uses the search in belog with no boundaries or sets a
custom date limit with boundaries that are too wide, the script
execution will experience a "Allowed memory of ... exhausted ..."
fatal error in PHP.

Because the search constraints are saved in the backend users uC
nonetheless, any further effort to access the belog module would result
in a fatal error, thus making it unusable.

This patch makes the belog module detect, if the script execution fails
because of an exhausted memory and reset the search constraints to its
initial values.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Felix P. +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Julian Geils +1
    • Jörg Bösche +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Tobi Kretschmann commented on patch set 1 10/08/19, 07:34

    Cherry Picked from branch master.
  2. Jörg Bösche voted on patch set 1 V +1 CR +1 10/08/19, 07:44

  3. TYPO3com voted on patch set 1 V +1 10/08/19, 07:51 Completed build in 16m 48s on Tue, 8 Oct, 07:51 AM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1258

  4. Steffen Frese voted on patch set 1 V +1 CR +1 10/08/19, 07:53

  5. Julian Geils voted on patch set 1 V +1 CR +1 10/08/19, 07:56

  6. Henning Liebe voted on patch set 1 CR +1 10/08/19, 08:50

  7. Sascha Rademacher voted on patch set 1 V +1 CR +1 10/08/19, 09:21

  8. Felix P. voted on patch set 1 CR +1 10/08/19, 09:56

  9. Tobi Kretschmann voted on patch set 1 V +2 CR +2 10/09/19, 06:22

  10. Tobi Kretschmann merged patch set 2 10/09/19, 06:22