Review 9.5 Abandoned

61916[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings

Daniel Goerz CR 0 V 0 Normal +128 −0 updated 10/08/19, 07:58

Commit message

Backend users each have a serialized array of individual user
configuration, called "uc" persisted in the be_users table.
Before TYPO3 9.5, the structure of this configuration could sometimes
contain stdClass objects, which is no longer supported. Logging in as
a backend user with such an outdated "uc" array would then crash several
parts of the TYPO3 backend, because the BackendUserConfiguration class
will try to access an stdClass type configuration like an array.

An UpgradeWizard called "BackendUserConfigurationUpdate" is now
provided, which allows to update any outdated "uc" structure of all
backend users.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 2

Review log 5

  1. Daniel Goerz commented on patch set 1 10/08/19, 07:38

    Cherry Picked from branch master.
  2. Jörg Bösche voted on patch set 1 V +1 CR +1 10/08/19, 07:43

  3. Mathias Brodala commented on patch set 1 CR -1 10/08/19, 07:53

    Waiting for public response on my concerns in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61874
  4. Oliver Hader commented on patch set 1 CR -1 10/08/19, 07:58

    Not a security issue per definition - but we must avoid introducing new unserialize invocations that do not use the second allowed_classes parameter, see https://www.php.net/manual/en/function.unserialize.php "options" section
  5. Daniel Goerz abandoned the change 10/08/19, 07:58