Review 9.5 Merged

61919[BUGFIX] Fix "Show" link in the context menu of page translations

Daniel Goerz CR +2 V +2 Normal +40 −15 updated 04/19/20, 10:02

Commit message

In the list module, when opening the context menu of a
"Page Translation" record, a "Show" link will be shown, which is
supposed to open the page in the frontend with the correct language.
However this link was broken, because the PageProvider class didn't
respect page translations at all.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Daniel Goerz commented on patch set 1 10/08/19, 13:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/08/19, 13:13 Completed build in 12m 37s on Tue, 8 Oct, 01:13 PM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1261

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 10/08/19, 13:19

  4. Daniel Goerz merged patch set 2 10/08/19, 13:19

  5. Daniel Goerz commented on patch set 2 01/16/20, 09:44

  6. Oliver Hader commented on patch set 2 04/18/20, 21:26

  7. Daniel Goerz commented on patch set 2 04/19/20, 10:02

    Damn, thats the 2nd time this happend to me :( I guess at least phpstan will catch those cases once we only backport to phpstan-enabled branches. Thanks for taking care, Christian