61926[TASK] Give better info about no records
Commit message
Review
-
Code review CR +2 Done
- Tobi Kretschmann +2
- Sascha Rademacher +1
- Jan Stockfisch +1
- Jörg Bösche +1
-
Verified V +2 Done
- Tobi Kretschmann +2
- Sascha Rademacher +1
- Jan Stockfisch +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1214
-
Susi Moog commented on patch set 1 10/10/19, 09:37
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 10/10/19, 09:55 Completed build in 18m 10s on Thu, 10 Oct, 09:55 AM Test Summary: 50730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1279
-
Jörg Bösche voted on patch set 1 V +1 CR +1 10/11/19, 07:50
-
Andreas Kienast commented on patch set 2 10/11/19, 07:56
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 10/11/19, 08:09 Completed build in 12m 50s on Fri, 11 Oct, 08:09 AM Test Summary: 50765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1297
-
Jörg Bösche voted on patch set 2 V +1 CR +1 10/11/19, 08:13
-
Tobi Kretschmann commented on patch set 2 CR -1 10/11/19, 08:59
RecordListController.php:555Unresolvedimho this is redundant because the same check happens in $lang->sL(). If that string does not contain LLL the input is returned as is. Thus the condition case is unnecessary. and can just be replaced with $ll = sprintf($lang->getLL('noRecordsOfTypeOnThisPage'), $lang->sL($GLOBALS['TCA'][$this->table]['ctrl']['title'])); -
Tobi Kretschmann voted on patch set 2 CR 0 10/11/19, 09:04
-
Jan Stockfisch commented on patch set 2 V -1 10/11/19, 09:15
Does not work for me in 9.5 -
Jan Stockfisch commented on patch set 2 V +1 10/11/19, 09:22
Tested in wrong context… -
Sascha Rademacher voted on patch set 2 V +1 CR +1 10/11/19, 10:34
-
Jan Stockfisch voted on patch set 2 CR +1 10/11/19, 11:21
-
Tobi Kretschmann voted on patch set 2 V +2 CR +2 10/11/19, 13:25
-
Tobi Kretschmann merged patch set 3 10/11/19, 13:25