Review 9.5 Merged

61930[BUGFIX] Prevent broken AND where statement in cObj->searchWhere()

Daniel Goerz CR +2 V +2 Easy +24 −5 updated 10/11/19, 07:12

Commit message

If searchWhere() in ContentObjectRenderer is called with search words
that are smaller than 3 characters in length, a broken " AND " where
statement will be returned, that, if put inside a database query, would
lead to a fatal error. In such a case, return an empty string to prevent addWhere call.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Daniel Goerz commented on patch set 1 10/10/19, 14:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/10/19, 15:17 Completed build in 20m 06s on Thu, 10 Oct, 03:17 PM Test Summary: 50733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1290

  3. Jörg Bösche voted on patch set 1 V +1 CR +1 10/11/19, 06:30

  4. Christian Eßl voted on patch set 1 V +1 CR +1 10/11/19, 06:57

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 10/11/19, 07:12

  6. Daniel Goerz merged patch set 2 10/11/19, 07:12