Review main Merged

61932[TASK] Future-proof Fluid template namespace imports

Claus Due CR +2 V +2 Easy +15 −14 updated 10/10/19, 12:55

Commit message

Corrects Fluid templates which use a space around the
equals sign in namespace imports - a notation which
will not be supported with Fluid 3.0. Has no effect on
current Fluid versions so is only a future-proofing fix.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Felix P. +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jörg Bösche +1
    • Felix P. +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 810

  1. Claus Due uploaded patch set 1 10/09/19, 09:33

  2. Claus Due updated the commit message in patch set 2 10/09/19, 09:34

  3. TYPO3com voted on patch set 1 V -1 10/09/19, 09:44 Completed build in 10m 56s on Wed, 9 Oct, 09:44 AM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37167

  4. TYPO3com voted on patch set 2 V +1 10/09/19, 09:53 Completed build in 13m 06s on Wed, 9 Oct, 09:53 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37168

  5. Sascha Rademacher voted on patch set 2 CR +1 10/10/19, 07:57

  6. Susi Moog voted on patch set 2 V +1 CR +1 10/10/19, 09:28

  7. Jörg Bösche voted on patch set 2 V +1 CR +1 10/10/19, 09:35

  8. Felix P. voted on patch set 2 V +1 CR +1 10/10/19, 10:02

  9. Georg Ringer voted on patch set 2 V +2 CR +2 10/10/19, 12:55

  10. Georg Ringer merged patch set 3 10/10/19, 12:55