Review main Merged

61937[BUGFIX] Add pre access check to install tool

Frank Nägler CR +2 V +2 Easy +33 −3 updated 10/10/19, 09:14

Commit message

If Install Tool is locked or access is not granted, silent configuration
update is not called.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1620

  1. Frank Nägler uploaded patch set 1 10/09/19, 14:47

  2. Frank Nägler voted on patch set 1 V -1 10/09/19, 14:58

  3. TYPO3com voted on patch set 1 V +1 10/09/19, 14:58 Completed build in 10m 38s on Wed, 9 Oct, 02:58 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37188

  4. Anja Leichsenring uploaded patch set 2 10/09/19, 15:20

  5. Anja Leichsenring commented on patch set 2 V +2 10/09/19, 15:20

    nothing to see here ...
  6. Anja Leichsenring wrote 10/09/19, 15:21

    Removed Verified+2 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  7. Anja Leichsenring commented on patch set 2 CR -2 10/09/19, 15:21

    nothing to see here
  8. Andreas Kienast uploaded patch set 3 10/09/19, 15:28

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/09/19, 15:30

  10. Anja Leichsenring updated the commit message in patch set 4 10/09/19, 15:30

  11. TYPO3com voted on patch set 2 V +1 10/09/19, 15:31 Completed build in 10m 48s on Wed, 9 Oct, 03:31 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37192

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/09/19, 15:31

  13. TYPO3com voted on patch set 3 V +1 10/09/19, 15:39 Completed build in 11m 23s on Wed, 9 Oct, 03:39 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37193

  14. TYPO3com voted on patch set 4 V +1 10/09/19, 15:42 Completed build in 11m 35s on Wed, 9 Oct, 03:42 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37194

  15. Sascha Rademacher voted on patch set 4 CR +1 10/10/19, 06:59

  16. Frank Nägler commented on patch set 4 V -1 10/10/19, 07:09

    will do some more tests, temporary -1
  17. Frank Nägler commented on patch set 4 V 0 10/10/19, 08:55

    ok, fine, looks good
  18. Tobi Kretschmann voted on patch set 4 V +1 CR +1 10/10/19, 09:08

  19. Anja Leichsenring voted on patch set 4 V +2 CR +2 10/10/19, 09:14

  20. Anja Leichsenring merged patch set 5 10/10/19, 09:14