61938[BUGFIX] Set tasks backend:lock & backend:unlock as not schedulable
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Sascha Rademacher +1
- Jörg Bösche +1
- Henning Liebe +1
- Christian Eßl +1
-
Verified V +2 Done
- Richard Haeser +2
- Sascha Rademacher +1
- Jörg Bösche +1
- Henning Liebe +1
- Christian Eßl +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Georg Ringer uploaded patch set 1 10/10/19, 03:22
-
Georg Ringer commented on patch set 1 10/10/19, 03:23
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 10/10/19, 03:34 Completed build in 11m 24s on Thu, 10 Oct, 03:34 AM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37196
-
Christian Eßl voted on patch set 1 V +1 CR +1 10/10/19, 05:43
-
Jörg Bösche commented on patch set 1 V +1 CR +1 10/10/19, 06:19
verified on master and v9.5.9 -
TYPO3com voted on patch set 1 V +1 10/10/19, 06:46 Completed build in 3h 35m 21s on Thu, 10 Oct, 06:46 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37196
-
Sascha Rademacher voted on patch set 1 V +1 CR +1 10/10/19, 06:50
-
Henning Liebe commented on patch set 1 V +1 CR +1 10/10/19, 07:08
looks good to me on master and 9.5 -
Richard Haeser voted on patch set 1 V +2 CR +2 10/10/19, 07:27
-
Richard Haeser merged patch set 2 10/10/19, 07:27
-
Benjamin Franzke commented on patch set 2 12/06/19, 09:26
Post-merge review: The schedulers *primary* task is to *schedule* tasks, not to execute them from the backend. The backend-execution is an additional functionality, because it's sometime handy for manual tasks/testing. This patch regresses and actually drops perfectly valid *scheduler* functionality: * Planned Maintenance locks: schedule a backend lock for a planned update or migration where you agreed to stop editing as of a certain date. * Regular edit-locks, e.g.: schedule a backend lock for let's say every friday as of 8pm schedule backend unlock on mondays at 8am. Therefore let's revert this patch. Patch is here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62551