Review 9.5 Merged

61939[BUGFIX] Reorder processing of TCA select items again

Tobi Kretschmann CR +2 V +2 Hard +577 −45 updated 03/06/20, 13:41

Commit message

It's now possible again to process items from foreign_table
configuration with the itemsProcFunc. After that pageTSconfig settings
can influence the items once again.

AbstractItemProvider->getStaticValues() is removed as it is not used
anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • André Buchmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • André Buchmann +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2128

Show 23 earlier messages
  1. Tobi Kretschmann uploaded patch set 1 10/10/19, 08:28

  2. TYPO3com voted on patch set 1 V +1 10/10/19, 08:42 Completed build in 13m 54s on Thu, 10 Oct, 08:42 AM Test Summary: 50750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1277

  3. Jörg Bösche voted on patch set 1 V +1 CR +1 10/10/19, 08:47

  1. Julian Geils voted on patch set 1 CR +1 10/10/19, 08:53

  2. Sascha Rademacher voted on patch set 1 V +1 CR +1 10/10/19, 09:08

  3. Susi Moog commented on patch set 1 CR -1 10/10/19, 09:26

    see master change.
  4. Tobi Kretschmann commented on patch set 1 10/16/19, 07:30

    Updated the patch set for master. Once everything is resolved I will update this patch set as well.
  5. Steve Lenz commented on patch set 1 V -1 CR -1 11/06/19, 16:04

    Reorder of `$staticItems = $fieldConfig['config']['items'];` produce a new issue. The value the reference column get also resolved as relation. So there are a wrong item in list of selected items. If I revoke the position of `$staticItems = $fieldConfig['config']['items'];` the bugfix works as expected.
  6. Steve Lenz wrote 11/12/19, 12:02

    Removed Code-Review-1 by Steve Lenz <lenz.steve@outlook.de>
  7. Tobi Kretschmann uploaded patch set 2 01/20/20, 09:16

  8. TYPO3com voted on patch set 2 V -1 01/20/20, 09:28 Completed build in 12m 13s on Mon, 20 Jan, 09:28 AM Test Summary: 30 of 74558 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1889

  9. Tobi Kretschmann rebased onto patch set 3 02/11/20, 08:53

  10. TYPO3com voted on patch set 3 V -1 02/12/20, 13:03 Completed build in 12m 40s on Wed, 12 Feb, 01:03 PM Test Summary: 30 of 74957 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-7

  11. André Buchmann uploaded patch set 4 02/24/20, 09:56

  12. TYPO3com voted on patch set 4 V +1 02/24/20, 10:08 Completed build in 12m 07s on Mon, 24 Feb, 10:08 AM Test Summary: 74381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-78

  13. Jörg Bösche commented on patch set 4 V +1 CR +1 02/24/20, 10:21

    Re-Vote because of changes in test class only.
  14. Torben Hansen commented on patch set 4 CR -1 02/25/20, 06:47

    AbstractItemProvider.php:1385 Unresolved

    This is used in v10 only and should not be backported to v9.5 (see #88659)
  15. Tobi Kretschmann uploaded patch set 5 02/25/20, 14:41

  16. TYPO3com voted on patch set 5 V -1 02/25/20, 14:41 Completed build in 22s on Tue, 25 Feb, 02:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-84

  17. Torben Hansen uploaded patch set 6 02/25/20, 15:45

  18. TYPO3com voted on patch set 6 V +1 02/25/20, 15:58 Completed build in 13m 01s on Tue, 25 Feb, 03:58 PM Test Summary: 74381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-85

  19. André Buchmann voted on patch set 6 V +1 CR +1 02/26/20, 11:07

  20. Torben Hansen voted on patch set 6 CR +1 02/26/20, 18:10

  21. Susi Moog updated the commit message in patch set 7 02/27/20, 13:14

  22. André Buchmann voted on patch set 7 V +1 CR +1 02/27/20, 13:23

  23. TYPO3com voted on patch set 7 V +1 02/27/20, 13:26 Completed build in 12m 02s on Thu, 27 Feb, 01:26 PM Test Summary: 74381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-103

  24. Benni Mack voted on patch set 7 V +2 CR +2 03/06/20, 13:41

  25. Benni Mack merged patch set 8 03/06/20, 13:41