Review main Merged

61944[TASK] Adjust composer.json declarations of system extensions

Oliver Hader CR +2 V +2 Normal +0 −98 updated 10/11/19, 06:52

Commit message

In order to compatible with https://getcomposer.org/doc/04-schema.md
composer.json declarations had to be adjusted and dropped previous
replace statements like this:

"replace": {
    "core": "*"
}

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Simon Gilli +1
    • Jörg Bösche +1
    • Felix P. +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 35

Show 15 more files

Review log 1012

  1. Oliver Hader uploaded patch set 1 10/10/19, 14:40

  2. Oliver Hader voted on patch set 1 CR -1 10/10/19, 14:43

  3. Oliver Hader commented on patch set 1 10/10/19, 14:43

    Not sure whether ``` "extra": { "typo3/cms": { "extension-key": "my_ext_key" } } ``` is missing...
  4. Oliver Hader commented on patch set 1 CR 0 10/10/19, 14:56

    Fine, "typo3-cms"/"extension-key" is defined for all packages in master That was introduced in https://review.typo3.org/q/Ife913038142e8ecc137d21d4d43e2cdf467fb0f9 (+1)
  5. TYPO3com voted on patch set 1 V -1 10/10/19, 15:00 Completed build in 16m 58s on Thu, 10 Oct, 03:00 PM Test Summary: 1 of 48110 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37220

  6. TYPO3com voted on patch set 1 V +1 10/10/19, 15:17 Completed build in 50m 59s on Thu, 10 Oct, 03:17 PM Test Summary: 47749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37220

  7. Simon Gilli voted on patch set 1 CR +1 10/10/19, 16:26

  8. Georg Ringer voted on patch set 1 V +1 CR +1 10/10/19, 19:58

  9. Jörg Bösche voted on patch set 1 CR +1 10/11/19, 06:28

  10. Felix P. voted on patch set 1 CR +1 10/11/19, 06:34

  11. Oliver Hader voted on patch set 1 V +2 CR +2 10/11/19, 06:52

  12. Oliver Hader merged patch set 2 10/11/19, 06:52