Review main Merged

61945[TASK] Provide AcceptanceTest for stand alone install tool

Anja Leichsenring CR +2 V +2 Hard +271 −14 updated 10/12/19, 07:49

Commit message

A simple test asserting the login and logout mechanics for
the stand alone install tool are functional.
Cards in the maintenance page received basic checks
ensuring no Javascript errors occur.

Additionally, typo3/testing-framework will be raised, so the
new tests gets integrated into the automatic bamboo run.
Used update command:
	composer update typo3/testing-framework

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 5

Review log 1731

Show 36 earlier messages
  1. Anja Leichsenring uploaded patch set 1 10/10/19, 15:05

  2. Anja Leichsenring uploaded patch set 2 10/10/19, 15:15

  3. TYPO3com voted on patch set 1 V -1 10/10/19, 15:16 Completed build in 30s on Thu, 10 Oct, 03:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37223

  4. TYPO3com voted on patch set 2 V -1 10/10/19, 15:16 Completed build in 30s on Thu, 10 Oct, 03:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37224

  5. Anja Leichsenring uploaded patch set 3 10/10/19, 15:17

  6. TYPO3com voted on patch set 3 V -1 10/10/19, 15:37 Completed build in 17m 39s on Thu, 10 Oct, 03:37 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37225

  1. TYPO3com voted on patch set 3 V +1 10/11/19, 06:53 Completed build in 15h 50m 50s on Fri, 11 Oct, 06:53 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37225

  2. Andreas Kienast voted on patch set 3 V +1 CR +1 10/11/19, 07:09

  3. Anja Leichsenring commented on patch set 3 V -1 10/11/19, 08:23

    we need a testing framework adaption for this to work. Blocked until that happens.
  4. Anja Leichsenring rebased onto patch set 4 10/11/19, 09:58

  5. TYPO3com voted on patch set 4 V +1 10/11/19, 10:10 Completed build in 11m 07s on Fri, 11 Oct, 10:10 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37243

  6. Anja Leichsenring uploaded patch set 5 10/11/19, 10:42

  7. Anja Leichsenring commented on patch set 5 CR -1 10/11/19, 10:53

    I will add another one.
  8. TYPO3com voted on patch set 5 V +1 10/11/19, 10:53 Completed build in 11m 29s on Fri, 11 Oct, 10:53 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37249

  9. Anja Leichsenring uploaded patch set 6 10/11/19, 13:55

  10. TYPO3com voted on patch set 6 V -1 10/11/19, 13:55 Completed build in 12s on Fri, 11 Oct, 01:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37265

  11. Anja Leichsenring uploaded patch set 7 10/11/19, 13:56

  12. Anja Leichsenring updated the commit message in patch set 8 10/11/19, 14:03

  13. TYPO3com voted on patch set 7 V -1 10/11/19, 14:06 Completed build in 09m 51s on Fri, 11 Oct, 02:06 PM Test Summary: 47506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37266

  14. TYPO3com voted on patch set 8 V -1 10/11/19, 14:15 Completed build in 11m 42s on Fri, 11 Oct, 02:15 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37268

  15. TYPO3com voted on patch set 7 V +1 10/11/19, 14:16 Completed build in 29m 52s on Fri, 11 Oct, 02:16 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37266

  16. TYPO3com voted on patch set 8 V +1 10/11/19, 14:31 Completed build in 38m 58s on Fri, 11 Oct, 02:31 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37268

  17. Anja Leichsenring uploaded patch set 9 10/11/19, 16:58

  18. TYPO3com voted on patch set 9 V -1 10/11/19, 16:58 Completed build in 15s on Fri, 11 Oct, 04:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37274

  19. Anja Leichsenring uploaded patch set 10 10/11/19, 17:54

  20. Anja Leichsenring updated the commit message in patch set 11 10/11/19, 17:59

  21. TYPO3com voted on patch set 10 V +1 10/11/19, 18:05 Completed build in 10m 48s on Fri, 11 Oct, 06:05 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37275

  22. TYPO3com voted on patch set 11 V +1 10/11/19, 18:10 Completed build in 10m 49s on Fri, 11 Oct, 06:10 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37276

  23. Andreas Kienast voted on patch set 11 V +1 CR +1 10/12/19, 07:48

  24. Anja Leichsenring voted on patch set 11 V +2 CR +2 10/12/19, 07:49

  25. Anja Leichsenring merged patch set 12 10/12/19, 07:49