61946[BUGFIX] Make sure only void tags will be self closing if value is empty
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2732
Show 47 earlier messages
-
Jo Hasenau uploaded patch set 1 10/10/19, 16:02
-
TYPO3com voted on patch set 1 V -1 10/10/19, 16:11 Completed build in 08m 46s on Thu, 10 Oct, 04:11 PM Test Summary: 47722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37226
-
TYPO3com commented on patch set 1 10/10/19, 17:32 Completed build in 11m 47s on Thu, 10 Oct, 05:32 PM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37228
-
Georg Ringer commented on patch set 1 10/10/19, 17:36
-
Jo Hasenau commented on patch set 1 10/10/19, 17:42
> Patch Set 1: > > (1 comment) Since isset is way faster than is_in_array I usually try to avoid the latter. Still can change it though, if CGL require it. -
TYPO3com commented on patch set 1 10/10/19, 17:43 Completed build in 10m 02s on Thu, 10 Oct, 05:43 PM Test Summary: 1 of 48089 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37230
-
Georg Ringer commented on patch set 1 10/10/19, 18:20
it is just far uglier to read, also pls remove everything below 8.7, not maintained anymore
-
Jo Hasenau commented on patch set 1 10/10/19, 19:40
> Patch Set 1: > > it is just far uglier to read, also pls remove everything below 8.7, not maintained anymore Aren't there ELTS releases for 6 and 7 anymore? -
Georg Ringer commented on patch set 1 10/10/19, 19:50
> Aren't there ELTS releases for 6 and 7 anymore? there are but handled via TYPO3 GmbH and not via gerrit -
Jo Hasenau uploaded patch set 2 10/10/19, 20:13
-
TYPO3com voted on patch set 2 V +1 10/10/19, 20:21 Completed build in 08m 33s on Thu, 10 Oct, 08:21 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37234
-
Jan Stockfisch commented on patch set 2 CR +1 10/11/19, 10:05
GeneralUtility.php:1691self::inList can be used here -
Sascha Rademacher voted on patch set 2 CR +1 10/11/19, 10:21
-
Jo Hasenau uploaded patch set 3 10/11/19, 10:29
-
Jo Hasenau commented on patch set 3 10/11/19, 10:37
> Patch Set 2: Code-Review+1 > > (1 comment)GeneralUtility.php:1679ReplyDoneGeneralUtility.php:1691see new patchsetGeneralUtility.php:1691ReplyDone -
TYPO3com voted on patch set 3 V +1 10/11/19, 10:40 Completed build in 11m 06s on Fri, 11 Oct, 10:40 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37246
-
Jan Stockfisch voted on patch set 3 CR +1 10/11/19, 10:50
-
Felix P. voted on patch set 3 CR +1 10/11/19, 11:10
-
Oliver Klee commented on patch set 3 10/11/19, 11:24
Please let's cover this with a regression test. -
Oliver Klee commented on patch set 3 10/11/19, 11:25
GeneralUtility.php:1692I propose putting this list of tags in a well-named private constant. -
Jo Hasenau commented on patch set 3 10/11/19, 11:28
> Patch Set 3: > > Please let's cover this with a regression test. OK - who is able to provide such a test? -
Oliver Klee commented on patch set 3 10/11/19, 11:40
> OK - who is able to provide such a test? Usually it's the task of the person who authored the change and hence knows the solved problem and the expected new behavior. If you need guidance, I can help on Slack. -
Benni Mack commented on patch set 3 CR -1 11/04/19, 15:43
GeneralUtility.php:1692Reply UnresolvedThat's a bummer though. the method is related to XML, not based on HTML(5), so this should be handled through XML schema. -
Oliver Hader commented on patch set 3 CR -1 11/04/19, 16:40
... and probably a test-case would be nice... by just looking into the code and the (short) Git commit message, I do not really see what the problem is and what the expected (correct) behavior should be. Thx in advance -
Jo Hasenau commented on patch set 3 11/04/19, 17:23
> Patch Set 3: Code-Review-1 > > ... and probably a test-case would be nice... by just looking into the code and the (short) Git commit message, I do not really see what the problem is and what the expected (correct) behavior should be. Thx in advance Actually the commit message exactly describes the problem: Non void tags are converted to self closing tags by the xml2tree parser as soon as they are empty. This should only happen to officially void tags and not to each tag without content between opening and closing tag. The rest including a code example can be found in the issue tracker. -
Jo Hasenau commented on patch set 3 CR -1 11/04/19, 17:39
According to the W3C there are some more void tags, so the list should be completed. https://www.w3.org/TR/2011/WD-html-markup-20110405/syntax.html#syntax-elements -
Oliver Hader commented on patch set 3 11/04/19, 18:03
> Patch Set 3: Code-Review-1 > > According to the W3C there are some more void tags, so the list should be completed. > https://www.w3.org/TR/2011/WD-html-markup-20110405/syntax.html#syntax-elements Maybe xml2tree is the wrong function for your use-case (which I currently fail to understand). In case the scope is the create and render valid HTML output, a proper DOM model should be used instead of using "array" as structure. PHP's DOMDocument is capable of dealing with DTD and namespaces in order avoid putting W3C specs to PHP. In case more flexibility is required on the validation part, HTMLpurifier might be an option as well... -
Jo Hasenau commented on patch set 3 11/04/19, 18:12
> Patch Set 3: > > > Patch Set 3: Code-Review-1 > > > > According to the W3C there are some more void tags, so the list should be completed. > > https://www.w3.org/TR/2011/WD-html-markup-20110405/syntax.html#syntax-elements > > Maybe xml2tree is the wrong function for your use-case (which I currently fail to understand). > In case the scope is the create and render valid HTML output, a proper DOM model should be used instead of using "array" as structure. PHP's DOMDocument is capable of dealing with DTD and namespaces in order avoid putting W3C specs to PHP. In case more flexibility is required on the validation part, HTMLpurifier might be an option as well... I just sent you a private message on slack so we don't have to use gerrit for a chat ;-) -
Benni Mack commented on patch set 3 01/15/20, 11:44
so we drop this one? -
Jo Hasenau commented on patch set 3 01/15/20, 12:29
If this is not done by the core, there currently is a copy of the modified method within L10nmgr, so it is not necessary to fix it in the core just to make the extension work properly. I would still like this to be fixed in the core too. -
Benni Mack commented on patch set 3 01/16/20, 11:01
> Patch Set 3: > > If this is not done by the core, there currently is a copy of the modified method within L10nmgr, so it is not necessary to fix it in the core just to make the extension work properly. > > I would still like this to be fixed in the core too. Sure, but that would be a new feature as discussed, very much in a new separate change not in this review, as it would be a different approach. -
Benni Mack abandoned the change 02/15/20, 09:39
I will abandon this change for now, we can restore this later-on if needed
GeneralUtility.php:1679