61948[TASK] Use no-cookie setting for vimeo by default
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1419
-
Guido Schmechel uploaded patch set 1 10/10/19, 20:42
-
TYPO3com voted on patch set 1 V -1 10/10/19, 20:52 Completed build in 09m 57s on Thu, 10 Oct, 08:52 PM Test Summary: 52 of 48345 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37235
-
Guido Schmechel commented on patch set 1 CR -1 10/11/19, 08:21
On it -
Guido Schmechel uploaded patch set 2 10/12/19, 10:23
-
TYPO3com voted on patch set 2 V +1 10/12/19, 10:32 Completed build in 09m 44s on Sat, 12 Oct, 10:32 AM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37283
-
Guido Schmechel commented on patch set 2 10/12/19, 11:37
Option 1: We use the existing no-cookie option. So we can deliver the whole thing for version 9 as a task. As implemented. Option 2: We build a feature like no-cookie. Only naming is called doNotTrack. This will only be available for v10. -
Guido Schmechel uploaded patch set 3 10/26/19, 11:54
-
TYPO3com voted on patch set 3 V -1 10/26/19, 12:12 Completed build in 15m 10s on Sat, 26 Oct, 12:12 PM Test Summary: 1 of 48430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37788
-
TYPO3com voted on patch set 3 V +1 01/19/20, 11:57 Completed build in 10m 11s on Sun, 19 Jan, 11:57 AM Test Summary: 70448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40085
-
Susi Moog rebased onto patch set 4 03/16/20, 18:19
-
Susi Moog commented on patch set 4 CR +1 03/16/20, 18:20
I like reusing the noCookie option. -
TYPO3com voted on patch set 4 V +1 03/16/20, 18:30 Completed build in 11m 40s on Mon, 16 Mar, 06:30 PM Test Summary: 72276 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1382
-
Georg Ringer commented on patch set 4 03/16/20, 18:58
is there a reason not setting that by default? -
Benni Mack commented on patch set 4 03/17/20, 08:15
> Patch Set 4: > > is there a reason not setting that by default? I guess for having a straight backport. -
Guido Schmechel commented on patch set 4 03/17/20, 08:25
> Patch Set 4: > > > Patch Set 4: > > > > is there a reason not setting that by default? > > I guess for having a straight backport. Right ;-) -
Benni Mack voted on patch set 4 CR +1 03/17/20, 08:53
-
Georg Ringer voted on patch set 4 V +1 CR +1 03/17/20, 10:22
-
Benni Mack voted on patch set 4 V +2 CR +2 03/17/20, 10:24
-
Benni Mack merged patch set 5 03/17/20, 10:24