Review main Merged

61951[TASK] Update ckeditor to 4.13.0

Andreas Kienast CR +2 V +2 Nightmare +1991 −1825 updated 10/14/19, 13:42

Commit message

This patch updates ckeditor to its latest release 4.13.0. However, the
original npm package has been deprecated and must be replaced by a new
package.

Used commands:

  yarn remove ckeditor
  yarn add --dev ckeditor4
  grunt build

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Jan Stockfisch +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Jan Stockfisch +1
    • TYPO3com +1 CI

Issues 1

Files 233

Show 213 more files

Review log 1217

  1. Andreas Kienast uploaded patch set 1 10/11/19, 07:27

  2. TYPO3com voted on patch set 1 V -1 10/11/19, 07:42 Completed build in 15m 42s on Fri, 11 Oct, 07:42 AM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37238

  3. TYPO3com voted on patch set 1 V +1 10/11/19, 07:43 Completed build in 32m 12s on Fri, 11 Oct, 07:43 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37238

  4. Markus Klein commented on patch set 1 10/11/19, 08:40

    incomplete sentence?
  5. Andreas Kienast commented on patch set 1 10/11/19, 08:44

    Reply

    Ack
  6. Andreas Kienast updated the commit message in patch set 2 10/11/19, 08:45

  7. TYPO3com voted on patch set 2 V +1 10/11/19, 08:56 Completed build in 10m 52s on Fri, 11 Oct, 08:56 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37239

  8. Jan Stockfisch commented on patch set 2 10/11/19, 11:01

    Unresolved

    What is about 8.7? Don't we need to take care of it too?
  9. Andreas Kienast updated the commit message in patch set 3 10/11/19, 11:17

  10. TYPO3com voted on patch set 3 V -1 10/11/19, 11:31 Completed build in 14m 10s on Fri, 11 Oct, 11:31 AM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37251

  11. TYPO3com voted on patch set 3 V +1 10/11/19, 12:07 Completed build in 1h 04m 09s on Fri, 11 Oct, 12:07 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37251

  12. Jan Stockfisch voted on patch set 3 V +1 CR +1 10/11/19, 15:10

  13. Oli Bartsch voted on patch set 3 CR +1 10/11/19, 17:01

  14. Daniel Goerz voted on patch set 3 V +1 CR +1 10/13/19, 16:01

  15. Oli Bartsch voted on patch set 3 V +1 10/14/19, 06:47

  16. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/14/19, 13:42

  17. Anja Leichsenring merged patch set 4 10/14/19, 13:42