Review main Merged

61955[FEATURE] Support env vars in YAML file names on import

Andreas Kienast CR +2 V +2 Normal +65 −0 updated 11/27/19, 09:49

Commit message

To have a variable import chain per environment (dev, stage etc) for
example, YAML files now may contain environment variables.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2534

Show 69 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/11/19, 12:04

  2. Andreas Kienast commented on patch set 1 CR -2 10/11/19, 12:04

    Needs some checks regarding security
  3. TYPO3com voted on patch set 1 V -1 10/11/19, 12:04 Completed build in 14s on Fri, 11 Oct, 12:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37255

  4. Andreas Kienast uploaded patch set 2 10/11/19, 12:05

  5. TYPO3com voted on patch set 2 V -1 10/11/19, 12:15 Completed build in 09m 58s on Fri, 11 Oct, 12:15 PM Test Summary: 47747 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37256

  6. TYPO3com voted on patch set 2 V +1 10/11/19, 12:19 Completed build in 23m 06s on Fri, 11 Oct, 12:18 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37256

  7. Mathias Brodala commented on patch set 2 10/11/19, 12:49

    YamlFileLoader.php:170

    Shouldn't this wrapped with a $this->hasFlag(self::PROCESS_PLACEHOLDERS) guard?
  8. Andreas Kienast commented on patch set 2 10/11/19, 12:56

    YamlFileLoader.php:170 Reply

    Ack
  9. Oliver Hader commented on patch set 2 10/11/19, 15:31

    > Patch Set 1: Code-Review-2 > > Needs some checks regarding security Not sure what you had in mind.. but `%env("whatever")%` has to be defined static in a YAML file, correct? If some dev/integrator writes `%env("QUERY_STRING")%` arbitrary YAML files could be read...
  1. Andreas Kienast voted on patch set 2 CR 0 10/12/19, 07:49

  2. Andreas Kienast uploaded patch set 3 11/09/19, 17:21

  3. TYPO3com voted on patch set 3 V -1 11/09/19, 17:21 Completed build in 11s on Sat, 9 Nov, 05:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38210

  4. Andreas Kienast uploaded patch set 4 11/09/19, 17:25

  5. TYPO3com voted on patch set 4 V +1 11/09/19, 17:36 Completed build in 11m 02s on Sat, 9 Nov, 05:36 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38212

  6. Susi Moog voted on patch set 4 CR +1 11/09/19, 18:54

  7. Susi Moog voted on patch set 4 V +1 11/09/19, 18:56

  8. Daniel Goerz commented on patch set 4 V -1 11/09/19, 19:45

    Does not work for me
  9. Benni Mack commented on patch set 4 CR -1 11/09/19, 19:54

    Feature, not a bug IMHO
  10. Susi Moog voted on patch set 4 V 0 CR 0 11/09/19, 20:03

  11. Oli Bartsch commented on patch set 4 11/09/19, 20:34

    > Patch Set 4: Code-Review-1 > > Feature, not a bug IMHO Thought the same but the possibility to use env vars in YAML is already documented here: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/SiteHandling/UsingEnvVars.html
  12. Daniel Goerz uploaded patch set 5 11/09/19, 20:42

  13. TYPO3com voted on patch set 5 V -1 11/09/19, 20:51 Completed build in 08m 09s on Sat, 9 Nov, 08:51 PM Test Summary: 48003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38234

  14. TYPO3com voted on patch set 5 V +1 11/09/19, 21:07 Completed build in 08m 03s on Sat, 9 Nov, 09:07 PM Test Summary: 48294 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38235

  15. Susi Moog voted on patch set 5 V +1 CR +1 11/10/19, 06:55

  16. Mathias Brodala commented on patch set 5 11/23/19, 21:23

    YamlFileLoaderTest.php:199

    I wonder if we could reduce this mockageddon with some VFS ...
  17. Daniel Siepmann voted on patch set 5 CR +1 11/25/19, 07:18

  18. Andreas Kienast commented on patch set 5 11/26/19, 13:53

    YamlFileLoaderTest.php:199 Reply Unresolved

    Feel free, I failed
  19. Mathias Brodala uploaded patch set 6 11/27/19, 08:37

  20. Mathias Brodala commented on patch set 6 V +1 CR +1 11/27/19, 08:38

    Unfortunately the YAML file loader is currently built to only support local file paths, URLs like VFS are not supported. So I've refactored the test to use real local files.
  21. TYPO3com voted on patch set 6 V -1 11/27/19, 08:52 Completed build in 13m 26s on Wed, 27 Nov, 08:52 AM Test Summary: 1 of 48509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38851

  22. Andreas Kienast commented on patch set 6 11/27/19, 08:53

    > Unfortunately the YAML file loader is currently built to only support local file paths, URLs like VFS are not supported. So I've refactored the test to use real local files. Thanks a lot!
  23. TYPO3com voted on patch set 6 V +1 11/27/19, 08:55 Completed build in 29m 15s on Wed, 27 Nov, 08:55 AM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38851

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 11/27/19, 09:49

  25. Andreas Kienast merged patch set 7 11/27/19, 09:49