Review main Merged

61957[TASK] Style error message on trying to access a restricted record

Christian Eßl CR +2 V +2 Easy +30 −8 updated 10/13/19, 15:56

Commit message

If editors try to edit a record, which they have no access to, the
EditFormController will show an error message like:

"Sorry, you didn't have proper permissions to perform this change."

plus an explanation why accessing the record failed. Unlike most other
parts of the backend, this error was only shown as plain text without
a flash message html container as styling.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Eßl uploaded patch set 1 10/11/19, 12:39

  2. TYPO3com voted on patch set 1 V +1 10/11/19, 13:03 Completed build in 18m 03s on Fri, 11 Oct, 01:03 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37259

  3. Georg Ringer commented on patch set 1 V +1 CR -1 10/12/19, 04:57

    Unresolved

    access

    EditDocumentController.php:1222 Unresolved

    this is undefined if title not set. I would move the if condition as inline there and not explizit compare to null but just ($title ? '<h4>...</h4>' : '') as empty string means also no title
  4. Christian Eßl uploaded patch set 2 10/12/19, 09:41

  5. TYPO3com voted on patch set 2 V +1 10/12/19, 09:50 Completed build in 09m 09s on Sat, 12 Oct, 09:50 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37282

  6. Georg Ringer voted on patch set 2 V +1 CR +1 10/12/19, 20:10

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 10/13/19, 15:56

  8. Daniel Goerz merged patch set 3 10/13/19, 15:56