Review main Merged

61960[BUGFIX] Do not try to persist fieldNames of type "none"

Christian Eßl CR +2 V +2 Easy +3 −1 updated 01/27/20, 16:16

Commit message

If a TCA field config of type="none" with the l10n_mode="exclude" is
present, the DataHandler will try to persist the field when saving a
translated version of the record, even though fields of type="none"
must not be persisted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Guido Schmechel +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Felix P. +1
    • Mathias Brodala +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1721

  1. Christian Eßl uploaded patch set 1 10/11/19, 14:00

  2. TYPO3com voted on patch set 1 V +1 10/11/19, 14:10 Completed build in 10m 45s on Fri, 11 Oct, 02:10 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37267

  3. Georg Ringer voted on patch set 1 CR +1 10/12/19, 04:48

  4. Oli Bartsch commented on patch set 1 10/14/19, 09:48

    DataMapProcessor.php:1393 Unresolved

    Could we please unify the condition params. Either declare them both as variables or use them both "inline". I prefer using both inline as this is the current approach, also way shorter and avoids single use variable declaration.
  5. Christian Eßl uploaded patch set 2 10/14/19, 15:36

  6. TYPO3com voted on patch set 2 V +1 10/14/19, 15:51 Completed build in 13m 41s on Mon, 14 Oct, 03:51 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37320

  7. Oli Bartsch commented on patch set 2 10/15/19, 05:36

    Unresolved

    Just one nitpick I overlooked yesterday. Could we write here "exclude" as there is no such value "true" for l10n_mode.
  8. Oli Bartsch updated the commit message in patch set 3 10/15/19, 05:47

  9. TYPO3com voted on patch set 3 V -1 10/15/19, 05:56 Completed build in 09m 00s on Tue, 15 Oct, 05:56 AM Test Summary: 2 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37324

  10. TYPO3com voted on patch set 3 V +1 10/15/19, 06:22 Completed build in 11m 36s on Tue, 15 Oct, 06:22 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37325

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 10/15/19, 06:23

  12. Guido Schmechel voted on patch set 3 CR +1 11/09/19, 14:06

  13. Mathias Brodala voted on patch set 3 V +1 CR +1 11/23/19, 21:31

  14. Jörg Bösche voted on patch set 3 CR +1 11/25/19, 15:40

  15. Henning Liebe voted on patch set 3 CR +1 01/14/20, 11:53

  16. Felix P. voted on patch set 3 CR +1 01/14/20, 12:13

  17. Steffen Frese voted on patch set 3 CR +1 01/15/20, 09:50

  18. Tobi Kretschmann voted on patch set 3 CR +1 01/15/20, 13:33

  19. Sascha Rademacher voted on patch set 3 CR +1 01/16/20, 09:02

  20. Benni Mack voted on patch set 3 V +2 CR +2 01/27/20, 16:16

  21. Benni Mack merged patch set 4 01/27/20, 16:16