Review main Abandoned

61964[BUGFIX] Remove api and no-cookie from video tag

Guido Schmechel CR 0 V 0 Easy +23 −1 updated 09/26/20, 12:03

Commit message

To avoid HTML validation errors, the options api
and no-cookie from the additionalConfig are ignored.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1419

  1. Guido Schmechel uploaded patch set 1 10/12/19, 12:39

  2. TYPO3com voted on patch set 1 V -1 10/12/19, 12:48 Completed build in 09m 01s on Sat, 12 Oct, 12:48 PM Test Summary: 1 of 48345 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37285

  3. TYPO3com commented on patch set 1 10/12/19, 13:51 Completed build in 11m 26s on Sat, 12 Oct, 01:51 PM Test Summary: 1 of 48345 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37287

  4. JarvisH voted on patch set 1 CR +1 10/22/19, 14:48

  5. Guido Schmechel rebased onto patch set 2 10/26/19, 11:52

  6. TYPO3com voted on patch set 2 V -1 10/26/19, 12:03 Completed build in 11m 20s on Sat, 26 Oct, 12:03 PM Test Summary: 1 of 48430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37786

  7. Oli Bartsch commented on patch set 2 10/27/19, 11:33

    VideoTagRenderer.php:110 Unresolved

    Maybe we could add a string array with the options to be excluded for videoTag. Personally I don't like to check for every single key in a comparison because maybe there will be more excluded options in the future and the comparison gets longer (multiple `$key !== ...`) and kind of confusing. So my suggestion is: protected $excludedOptions = [ 'api', 'no-cookie' ]; and then just check with !in_array($key, $this->excludedOptions, true)
  8. Guido Schmechel voted on patch set 2 CR -1 10/27/19, 12:06

  9. Guido Schmechel uploaded patch set 3 10/30/19, 23:08

  10. TYPO3com voted on patch set 3 V +1 10/30/19, 23:18 Completed build in 09m 50s on Wed, 30 Oct, 11:18 PM Test Summary: 48083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37878

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 10/31/19, 07:45

  12. Benni Mack commented on patch set 3 CR -1 11/08/19, 13:53

    yeah, I see your point, but this is actually killing YouTube integrations, which we actually implemented specifically for privacy reasons. https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.6.x/Breaking-84843-UseNo-cookieDomainForYoutubeByDefault.html# So this is somehow "let's get rid of it again". I feel like we should add the "api" and "no-cookie" properties on YouTube and Vimeo renderer, or at least: only respect them there. Blacklisting usually seems to be a "bad idea" as we need to update this blacklist on a regular basis ("I have use case XYZ...").
  13. Frank Nägler commented on patch set 3 11/08/19, 14:00

    using additionalConfig for additional attributes is the wrong way (two meanings for the same configuration), this was introduced here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/53356 There should be a dedicated setting for additional attributes. I agree also with Benni here, blacklisting is really no good idea.
  14. Oli Bartsch commented on patch set 3 V 0 CR 0 11/08/19, 14:05

    > Patch Set 3: Code-Review-1 > > yeah, I see your point, but this is actually killing YouTube integrations, which we actually implemented specifically for privacy reasons. > > https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.6.x/Breaking-84843-UseNo-cookieDomainForYoutubeByDefault.html# > > So this is somehow "let's get rid of it again". I feel like we should add the "api" and "no-cookie" properties on YouTube and Vimeo renderer, or at least: only respect them there. > > Blacklisting usually seems to be a "bad idea" as we need to update this blacklist on a regular basis ("I have use case XYZ..."). Thanks for the feedback. I agree with you about the privacy and also that blacklisting is a bad approach. But I don't get, how this patch should break the YouTube integration as this only affects the VideoTagRenderer AFAICS.
  15. Guido Schmechel commented on patch set 3 12/24/19, 11:31

    Ping :-) How should we proceed here?
  16. JarvisH commented on patch set 3 01/01/20, 12:46

    Happy new year everyone! My understanding of this issue, is that additionalConfig is not really needed at all for the VideoTagRenderer class, as additionalAttributes already exist for this purpose. To avoid breaking any existing use of additionalConfig to add attributes, we blacklist the already mentioned no-cookie and api keys for Typo3 v9. Blacklisting should pose no issues, as no new keys will be added to Typo3 v9 (correct me if I'm wrong) In Typo3 v10 however, additionalConfig should be removed completely from the VideoTagRenderer class. Any thoughts?
  17. Benni Mack updated the commit message in patch set 4 05/25/20, 18:42

  18. TYPO3com voted on patch set 4 V -1 05/25/20, 19:13 Completed build in 24m 13s on Mon, 25 May, 07:13 PM Test Summary: 1 of 74298 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3527

  19. Guido Schmechel abandoned the change 09/26/20, 12:03