Review main Merged

61965[BUGFIX] Prevent PageTypeDecorator from matching index too generously

Guido Schmechel CR +2 V +2 Normal +73 −1 updated 01/20/20, 08:17

Commit message

Pages that have slugs that end with the configured index
are now no longer matched falsely by the PageTypeDecorator.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Markus Klein +1
    • Felix P. +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1822

  1. Guido Schmechel uploaded patch set 1 10/12/19, 13:01

  2. Guido Schmechel commented on patch set 1 10/12/19, 13:03

    Only a first approach. Configuration see ticket. Breaking: The start page is then no longer available with "index.html".
  3. TYPO3com voted on patch set 1 V +1 10/12/19, 13:10 Completed build in 08m 40s on Sat, 12 Oct, 01:10 PM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37286

  4. Tymoteusz Motylewski commented on patch set 1 10/12/19, 21:27

    Can you please cover the change with test?
  5. Guido Schmechel commented on patch set 1 10/12/19, 21:43

    > Patch Set 1: > > Can you please cover the change with test? There are a two things to clarify: 1.) Is this change the right way to go? 2.) The complete class does not have any tests yet. I would suggest a follow up patch that adds tests for this class. What do you think about that? And of course i would need a lot of support for tests ;-)
  6. Tobi Kretschmann voted on patch set 1 CR +1 01/14/20, 10:25

  7. Markus Klein commented on patch set 1 CR -1 01/15/20, 14:05

    PageTypeDecorator.php:67 Unresolved

    This is a breaking change. Config like: 0: .html 123: .json formerly created /index.html /index.json /subpage.html /subpage.json now: /.html /.json /subpage.html /subpage.json
  8. Markus Klein commented on patch set 1 01/15/20, 14:08

    PageTypeDecorator.php:214 Unresolved

    I think this needs to be fixed rather here with the regex. something like '^(' . $name . $indexPattern . '(?:' . implode('|', $regularItems) . '))';
  9. Daniel Goerz uploaded patch set 2 01/16/20, 15:17

  10. Susi Moog voted on patch set 2 V +1 CR +1 01/16/20, 15:19

  11. Oliver Hader commented on patch set 2 CR -1 01/16/20, 15:25

    PageTypeDecorator.php:67 Unresolved

    don't see a relation here...

    EnhancerSiteRequestTest.php:602 Unresolved

    pathSuffix not required here (only used when called in parent test-case)
  12. Susi Moog commented on patch set 3 01/16/20, 15:25

    Published edit on patch set 2.
  13. TYPO3com voted on patch set 2 V +1 01/16/20, 15:36 Completed build in 18m 01s on Thu, 16 Jan, 03:36 PM Test Summary: 70391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40051

  14. TYPO3com voted on patch set 3 V -1 01/16/20, 15:40 Completed build in 13m 20s on Thu, 16 Jan, 03:40 PM Test Summary: 70157 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40053

  15. TYPO3com voted on patch set 3 V +1 01/16/20, 15:59 Completed build in 45m 14s on Thu, 16 Jan, 03:59 PM Test Summary: 70460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40053

  16. Tobi Kretschmann voted on patch set 3 CR +1 01/17/20, 06:54

  17. Felix P. voted on patch set 3 CR +1 01/17/20, 08:40

  18. Sascha Rademacher voted on patch set 3 CR +1 01/17/20, 09:24

  19. Markus Klein voted on patch set 3 CR +1 01/17/20, 11:39

  20. Susi Moog voted on patch set 3 V +1 CR +1 01/17/20, 16:23

  21. Benni Mack voted on patch set 3 V +2 CR +2 01/18/20, 16:39

  22. Benni Mack merged patch set 4 01/20/20, 08:17