Review main Merged

61967[TASK] Fix return type annotation of get_dirs method

Daniel Siepmann CR +2 V +2 Easy +2 −1 updated 10/18/19, 10:39

Commit message

As three different return types can be returned, they should all be
documented. This allows for better autocompletion and type safety through
static code analysis.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Daniel Siepmann uploaded patch set 1 10/14/19, 08:57

  2. Daniel Siepmann uploaded patch set 2 10/14/19, 08:59

  3. TYPO3com voted on patch set 1 V +1 10/14/19, 09:09 Completed build in 11m 31s on Mon, 14 Oct, 09:09 AM Test Summary: 47981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37297

  4. TYPO3com voted on patch set 2 V +1 10/14/19, 09:11 Completed build in 12m 31s on Mon, 14 Oct, 09:11 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37298

  5. Oli Bartsch commented on patch set 2 10/14/19, 09:22

    GeneralUtility.php:2204

    Could we also adjust this like "If no path, the return value is null. If directories couldn't be read the return value is 'error'.", because "is noting" isn't correct IMO.
  6. Oliver Klee commented on patch set 3 10/14/19, 10:00

    Published edit on patch set 2.
  7. Oliver Klee commented on patch set 3 CR +1 10/14/19, 10:01

    GeneralUtility.php:2204 Reply

    Done
  8. Daniel Siepmann voted on patch set 3 V +1 CR +1 10/14/19, 10:02

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 10/14/19, 10:13

  10. TYPO3com voted on patch set 3 V +1 10/14/19, 10:17 Completed build in 12m 04s on Mon, 14 Oct, 10:17 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37301

  11. Tobi Kretschmann voted on patch set 3 CR +1 10/16/19, 06:52

  12. Frank Nägler voted on patch set 3 V +2 CR +2 10/18/19, 10:38

  13. Frank Nägler merged patch set 4 10/18/19, 10:39